Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty conversation list on import media [WPB-10483] 🍒 #3401

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 28, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-10483 [Android] empty conversation list when sharing image using sharing extention


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • updating conversation list was not executed on main dispatcher
  • updating same state from different observers may cause race condition

Causes (Optional)

Random empty conversation list

Solutions

  • Introduce separate state for avatar asset
  • update conversation list on main dispatcher

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS labels Aug 28, 2024
@Garzas Garzas enabled auto-merge August 29, 2024 10:57
Copy link

@Garzas Garzas added this pull request to the merge queue Aug 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.48%. Comparing base (0b6296e) to head (6df5a73).
Report is 241 commits behind head on develop.

Files with missing lines Patch % Lines
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3401   +/-   ##
========================================
  Coverage    44.48%   44.48%           
========================================
  Files          464      464           
  Lines        15507    15507           
  Branches      2593     2593           
========================================
  Hits          6899     6899           
  Misses        7875     7875           
  Partials       733      733           
Files with missing lines Coverage Δ
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6296e...6df5a73. Read the comment docs.

Merged via the queue into develop with commit 42c16e9 Aug 29, 2024
11 of 12 checks passed
@Garzas Garzas deleted the fix/import-media-empty-conversations-cherry-pick branch August 29, 2024 11:39
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3401.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3401.apk is available for download

@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants