bitnami/postgresql wrapper to use in different bots and related services

[amitsagtani97]

Ticket - https://wearezeta.atlassian.net/browse/SQPIT-574

This the wrapper chart for bitnami/postgresql that can be used in different bots and related services.
An example use case - #2935

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[jschaul]

This should not be called -external. Since postgres from this chart runs inside kubernetes.

(The cassandra-external chart forwards traffic to cassandra deployed outside kubernetes on bare VMs. This is different.)

I'm not sure why we need a hand-rolled postgres helm chart here. There are many postgres charts maintained by the community, for example from bitnami, here: https://github.com/bitnami/charts/tree/main/bitnami/postgresql

Let's use their existing chart instead of needing to maintain a helm chart on software we do not develop.

If you need to re-host this helm chart as part of wire-server (why though?), you could require a third-party helm chart using a requirements.yaml file. But I don't see the benefit really, just use the third-party postgres chart wherever you wish to make use of it.

Your PR does not link to any issue / jira ticket so unfortunately I don't see the added value from this PR, if there might be a usecase I can't easily imagine, please provide more context.

[amitsagtani97]

This should not be called -external. Since postgres from this chart runs inside kubernetes.

(The cassandra-external chart forwards traffic to cassandra deployed outside kubernetes on bare VMs. This is different.)

I'm not sure why we need a hand-rolled postgres helm chart here. There are many postgres charts maintained by the community, for example from bitnami, here: https://github.com/bitnami/charts/tree/main/bitnami/postgresql

Let's use their existing chart instead of needing to maintain a helm chart on software we do not develop.

If you need to re-host this helm chart as part of wire-server (why though?), you could require a third-party helm chart using a requirements.yaml file. But I don't see the benefit really, just use the third-party postgres chart wherever you wish to make use of it.

Your PR does not link to any issue / jira ticket so unfortunately I don't see the added value from this PR, if there might be a usecase I can't easily imagine, please provide more context.

I was little worried if the latest postgresql versions will work with the existing bots, and in the Bitnami chart I tried to replace the image and tags to use older postgresql version, but that didn't worked.
But, the latest versions of Postgresql(at least 14) works with bots, so removing this custom chart and replacing with Bitnami one as you suggested.

[jschaul]

why do you need more than one replica in your use case (bots)? Would it not be sufficient to have one single replica (and no read replicas)?

Perhaps the first line architecture: replication could be changed to architecture: standalone (already the default). If not, please motivate why you need higher availability here at this level, and what this chart is used for (and also where it is used).

[jschaul]

Ugh. Can you remove the whole auth block? There should never be any default passwords in plaintext. The user of a helm chart should specify their own passwords. Same for database name and username. Please remove the whole auth block here.

[amitsagtani97]

fixed

[jschaul]

All of the values inside values.yaml currently have no effect. If you wish to override the defaults provided inside the upstream values.yaml, here: https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml, then you need to indent them under a top-level postgresql: section.

[amitsagtani97]

Fixed 👍

[jschaul]

Looks good now! (I added one small commit to add the chart to the list of charts to be released, this list is hardcoded inside the Makefile currently)