bitnami/postgresql wrapper to use in different bots and related services #3012
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| This is the PostgreSQL Bitnami chart. | ||
|
|
||
| Configure the values.yaml file to create the database, username, password and other configuration. | ||
| List of parameters available - https://artifacthub.io/packages/helm/bitnami/postgresql#parameters | ||
|
|
||
| For persisting data, you can configure your choice of storageClass with your provisioner. | ||
|
|
||
| Or, create a storage class and of PVs based on no. of replicas with no provisioner - | ||
| ``` | ||
| apiVersion: storage.k8s.io/v1 | ||
| kind: StorageClass | ||
| metadata: | ||
| name: local-storage | ||
| provisioner: kubernetes.io/no-provisioner | ||
| volumeBindingMode: WaitForFirstConsumer | ||
| reclaimPolicy: Retain | ||
| allowVolumeExpansion: true | ||
|
|
||
| --- | ||
|
|
||
| Prepare volume on host and give right permissions - | ||
| mkdir -p /data/local-storage | ||
| chmod -R 775 /data/local-storage | ||
|
|
||
| --- | ||
| apiVersion: v1 | ||
| kind: PersistentVolume | ||
| metadata: | ||
| name: local-pv | ||
| spec: | ||
| capacity: | ||
| storage: 10Gi | ||
| accessModes: | ||
| - ReadWriteMany | ||
| persistentVolumeReclaimPolicy: Retain | ||
| storageClassName: local-storage | ||
| hostPath: | ||
| path: /data/local-storage | ||
| ``` | ||
|
|
||
| To deploy the helm chart - | ||
| ``` | ||
| helm install postgresql charts/postgresql --values charts/postgresql/values.yaml | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| dependencies: | ||
| - name: postgresql | ||
| version: 11.9.8 | ||
| repository: https://charts.bitnami.com/bitnami |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| architecture: replication | ||
| global: | ||
| storageClass: local-storage | ||
| auth: | ||
| replicationPassword: externalPostgresql | ||
| postgresPassword: externalPostgresql | ||
| username: externalPostgresql | ||
| password: externalPostgresql | ||
| database: externalPostgresql | ||
|
There was a problem hiding this comment. Ugh. Can you remove the whole auth block? There should never be any default passwords in plaintext. The user of a helm chart should specify their own passwords. Same for database name and username. Please remove the whole auth block here. |
||
| readReplicas: | ||
| name: read | ||
| replicaCount: 2 | ||
| replication: | ||
| numSynchronousReplicas: 2 | ||
|
There was a problem hiding this comment. why do you need more than one replica in your use case (bots)? Would it not be sufficient to have one single replica (and no read replicas)? Perhaps the first line |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the values inside
values.yamlcurrently have no effect. If you wish to override the defaults provided inside the upstream values.yaml, here: https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml, then you need to indent them under a top-levelpostgresql:section.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍