Fix the issue that the initial values of the form on free listings editing page may be empty #2698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes the issue that the initial values of the form on free listings editing page may be empty.
Root cause
Since the values fetched from the APIs are updated asynchronously via
useEffect
, there is a chance that the default empty array in the wp-data store may be passed as the initial values to the form. As a result, empty form fields may appear occasionally when editing free listings because the empty array can pass checks inSetupFreeListings
.The issue usually happens on the shipping time data because it's almost always the last to be fetched.
Kapture.2024-11-28.at.18.57.41.mp4
Detailed test instructions:
Changelog entry