Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.9.1 #2708

Merged
merged 119 commits into from
Dec 3, 2024
Merged

Release 2.9.1 #2708

merged 119 commits into from
Dec 3, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2024

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.9.1
    git checkout release/2.9.1
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.9.1  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.9.1
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.9.1   --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.9.1
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Confirm the release using the activation link from your email.
    When releasing to WordPress.org, “release notifications” have been enabled, so each committer will be sent an email with an action link to confirm the release. This must be done after committing in SVN before the release becomes available. See the following page for releases pending notifications: https://wordpress.org/plugins/developers/releases/
  3. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.9.1, generate GitHub release notes, and paste them as a comment here.
  4. Merge this PR after the new release is successfully created and the version tags are updated.
  5. Merge trunk to develop (PR), if applicable for this repo.
  6. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  7. Mark related ideas complete on the feature requests page.

Add Shipping Max time column in gla_shipping_times Table
tomalec and others added 22 commits November 30, 2024 20:28
Fix the failed E2E test case introduced by pull request 2698
…hase-1

Update shippings settings phase 1
Omit optional arguments

Co-authored-by: Tomek Wytrębowicz <[email protected]>
Prevent translations from being called early
…ng-times-error

Avoid errors caused by automatically saving invalid shipping times during onboarding
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 52.30126% with 114 lines in your changes missing coverage. Please review.

Project coverage is 65.6%. Comparing base (727441b) to head (df38f74).
Report is 10 commits behind head on trunk.

Files with missing lines Patch % Lines
src/Exception/InvalidVersion.php 0.0% 19 Missing ⚠️
src/Exception/ExtensionRequirementException.php 0.0% 12 Missing ⚠️
...DependencyManagement/ThirdPartyServiceProvider.php 0.0% 10 Missing ⚠️
src/DB/Migration/Migration20240813T1653383133.php 0.0% 9 Missing ⚠️
.../Exception/RuntimeExceptionWithMessageFunction.php 0.0% 8 Missing ⚠️
src/Proxies/WC.php 22.2% 7 Missing ⚠️
...ponents/free-listings/setup-free-listings/index.js 0.0% 4 Missing and 2 partials ⚠️
...trollers/MerchantCenter/ShippingTimeController.php 84.8% 5 Missing ⚠️
...-time/shipping-time-setup/getCountriesTimeArray.js 0.0% 3 Missing and 1 partial ⚠️
.../free-listings/setup-free-listings/form-content.js 0.0% 3 Missing and 1 partial ⚠️
... and 14 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             trunk   #2708     +/-   ##
=========================================
+ Coverage     65.1%   65.6%   +0.5%     
- Complexity    4658    4678     +20     
=========================================
  Files          812     819      +7     
  Lines        24578   24753    +175     
  Branches      1254    1275     +21     
=========================================
+ Hits         15990   16232    +242     
+ Misses        8416    8346     -70     
- Partials       172     175      +3     
Flag Coverage Δ
js-unit-tests 63.4% <65.3%> (+1.2%) ⬆️
php-unit-tests 66.1% <42.8%> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
google-listings-and-ads.php 75.0% <ø> (ø)
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
...time-setup/add-time-button/add-time-modal/index.js 100.0% <100.0%> (+88.9%) ⬆️
...me-input/edit-time-button/edit-time-modal/index.js 94.1% <100.0%> (+87.5%) ⬆️
.../shipping-time-setup/countries-time-input/index.js 91.7% <100.0%> (+81.7%) ⬆️
...g-time/shipping-time-setup/min-max-inputs/index.js 100.0% <100.0%> (ø)
...ing-time/shipping-time-setup/time-stepper/index.js 100.0% <100.0%> (ø)
...inimum-order-card/calculateValueFromGroupChange.js 100.0% <ø> (ø)
...oupShippingRatesByCurrencyFreeShippingThreshold.js 100.0% <ø> (ø)
...n-section/minimum-order-card/minimum-order-card.js 96.0% <100.0%> (ø)
... and 43 more

... and 5 files with indirect coverage changes

@puntope
Copy link
Contributor

puntope commented Dec 3, 2024

What's Changed

[Add] New Features 🎉

[Update] Updated ✨

[Fix] Fixes 🛠

[Tweak] Tweaked 🔧

[Dev] Developer-facing changes 🧑‍💻

Full Changelog: 2.9.0...2.9.1

@puntope puntope merged commit a19ae25 into trunk Dec 3, 2024
@puntope puntope deleted the release/2.9.1 branch December 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants