Update shippings settings phase 1

[ianlin]

Changes proposed in this Pull Request:

Project: pcTzPl-2qP-p2

This is the umbrella PR that contains all the changes for shipping phase 1 implementation. The PRs includes:

• Add Shipping Max time column in gla_shipping_times Table #2520
• Adjust auto-sync shipping option #2526
• Fix issue with comma separators for Shipping Rates #2527
• Update the shipping time controllers to handle the maximum shipping time #2590
• Update UI to support minimum and maximum shipping times. #2594
• Update Add/Edit Shipping Time Modals to support minimum and maximum shipping times stepper #2609
• Adjust e2e tests for minimum and maximum shipping times #2619
• Add free shipping order value condition for shipping phase 1 #2686

Screenshots:

Detailed test instructions:

All the PRs have already been reviewed and tested, but it might be good to have an extra set of eyes to double check everything works as expected.

Additional details:

Changelog entry

Update - New shipping settings: phase 1

[codecov]

Codecov Report

Attention: Patch coverage is 71.76471% with 48 lines in your changes missing coverage. Please review.

Project coverage is 65.7%. Comparing base (399add5) to head (48fb03c).
Report is 92 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/DB/Migration/Migration20240813T1653383133.php	0.0%	9 Missing ⚠️
...trollers/MerchantCenter/ShippingTimeController.php	84.8%	5 Missing ⚠️
...-time/shipping-time-setup/getCountriesTimeArray.js	0.0%	3 Missing and 1 partial ⚠️
.../free-listings/setup-free-listings/form-content.js	0.0%	3 Missing and 1 partial ⚠️
...ponents/free-listings/setup-free-listings/index.js	0.0%	2 Missing and 2 partials ⚠️
js/src/hooks/useSaveShippingTimes.js	0.0%	3 Missing and 1 partial ⚠️
src/DB/Table/ShippingTimeTable.php	0.0%	4 Missing ⚠️
.../components/adaptive-form/adaptive-form-context.js	0.0%	3 Missing ⚠️
...hipping-time/shipping-time-setup/countries-form.js	0.0%	3 Missing ⚠️
...condition-section/order-value-condition-section.js	33.3%	2 Missing ⚠️
... and 5 more

Additional details and impacted files

@@             Coverage Diff              @@
##             develop   #2699      +/-   ##
============================================
+ Coverage       62.2%   65.7%    +3.5%     
- Complexity         0    4671    +4671     
============================================
  Files            335     818     +483     
  Lines           5147   24701   +19554     
  Branches        1256    1275      +19     
============================================
+ Hits            3204   16230   +13026     
- Misses          1769    8296    +6527     
- Partials         174     175       +1     

Flag	Coverage Δ
js-unit-tests	63.5% <69.5%> (+1.2%)	⬆️
php-unit-tests	66.3% <74.7%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...listings/configure-product-listings/checkErrors.js	100.0% <100.0%> (ø)
...time-setup/add-time-button/add-time-modal/index.js	100.0% <100.0%> (+88.9%)	⬆️
...me-input/edit-time-button/edit-time-modal/index.js	94.1% <100.0%> (+87.5%)	⬆️
.../shipping-time-setup/countries-time-input/index.js	91.7% <100.0%> (+81.7%)	⬆️
...g-time/shipping-time-setup/min-max-inputs/index.js	100.0% <100.0%> (ø)
...ing-time/shipping-time-setup/time-stepper/index.js	100.0% <100.0%> (ø)
...inimum-order-card/calculateValueFromGroupChange.js	100.0% <ø> (ø)
...oupShippingRatesByCurrencyFreeShippingThreshold.js	100.0% <ø> (ø)
...n-section/minimum-order-card/minimum-order-card.js	96.0% <100.0%> (ø)
...-order-form-modals/add-minimum-order-form-modal.js	100.0% <ø> (ø)
... and 28 more

... and 474 files with indirect coverage changes

[puntope]

Do we need to update the applicable version here in the migration file?

[puntope]

E2E tests seem to fail

https://github.com/woocommerce/google-listings-and-ads/actions/runs/12087559628/job/33709246270

E2E tests failing

[eason9487]

Had a quick look at the frontend code and wanted to report a few minor issues that could be fixed quickly.

[ianlin]

@puntope

Do we need to update the applicable version here in the migration file?

I think normally it would be updated manually when doing the release. (See the 5th checkbox in the release PR).

Also wanted to discuss maybe we may want to release this new shipping phase 1 as 2.10.0?

E2E tests seem to fail

Thanks for testing it, I missed checking e2e part. I fixed the e2e related to shipping phase 1, however, the e2e test still failed using the branch of this PR. It also failed when I ran e2e on the develop branch. Given the G4W release time is tomorrow, I will create a follow up issue regarding the e2e tests and we can check that after it release. WDYT?

[ianlin]

@eason9487

Had a quick look at the frontend code and wanted to report a few minor issues that could be fixed quickly.

Thanks for catching them, I've updated the code regarding your suggestions.

[puntope]

@ianlin I approved #2705 (review) That seems to be fixing the E2E

However- there are some conflicts

Just some conflicts in the tests

[eason9487]

Thanks for the additional adjustments.

It also failed when I ran e2e on the develop branch.

E2E on the develop branch has been fixed by #2705. I also merged it into this PR and resolved the code conflict in 48fb03c.

[ianlin]

Thanks @eason9487 and @puntope's team work, merging it now.