Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/add-to-cart-button-text-breaking: fix: prevent product list products' button text from wrapping mid word, mentioned in https://github.com/woocommerce/woocommerce/issues/30200 #1785

Closed

Conversation

9ete
Copy link
Contributor

@9ete 9ete commented Sep 18, 2021

No description provided.

@9ete 9ete requested a review from a team as a code owner September 18, 2021 00:13
@9ete 9ete requested review from opr and removed request for a team September 18, 2021 00:13
@9ete
Copy link
Contributor Author

9ete commented Sep 18, 2021

This commit addresses the WooCommerce issue #30200 https://github.com/woocommerce/woocommerce/issues/30200

@Aljullu
Copy link
Contributor

Aljullu commented Sep 21, 2021

Thanks for opening this PR @hawkeye126! I will wait reviewing it until there is a resolution of the discussion in #1787.

For the next steps, I would suggest if you could add testing instructions to the PR (even if you copy & paste it from the issue you mentioned). Adding before & after screenshots is also very useful. Also, you don't need to include a link to the issue you are fixing in the PR title, you can do so in the PR description, that helps keeping PR titles shorter. 🙂

@9ete
Copy link
Contributor Author

9ete commented Sep 22, 2021

Thanks for the feedback @Aljullu, that all makes sense to me. I will add the additional info via the other PR I open for this task as you advised.

@Aljullu
Copy link
Contributor

Aljullu commented Sep 26, 2021

Closing as this is superseded now by #1797.

@Aljullu Aljullu closed this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants