Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid text in buttons breaking in the middle of words #1797

Merged
merged 2 commits into from
Sep 26, 2021

Conversation

9ete
Copy link
Contributor

@9ete 9ete commented Sep 25, 2021

Fixes #1787.

Testing instructions

  • Revert "Fixed buttons word break (Fixed buttons word break #1624)"
  • fix/1787: add break word mixin to fix button word break issue on download buttons with long text

@9ete
Copy link
Contributor Author

9ete commented Sep 25, 2021

Fixed via reverting #1624 which applies a word-break: break-all style to all elements with the class .button and then to add the break-all style specifically to the download buttons as specified in the reverted issue.

Test Steps:
Install and activate all the required plugins.
Complete the onboarding setup wizard.
Choose the Storefront theme.
Add Some Products.
Go to Appearance->Customize.
Select WooCommerce->Product catalog option.
Set product per rows value to 6.
Observe that "Add to Cart" button text now does not appear misaligned.

Before:

Screen Shot 2021-09-25 at 2 39 43 PM

After:

Screen Shot 2021-09-25 at 2 39 58 PM

@Aljullu Aljullu changed the title fix/1787 Avoid text in buttons breaking in the middle of words Sep 26, 2021
@Aljullu Aljullu added the category: styles Issues related to styling label Sep 26, 2021
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great, thanks for creating this PR with this solution, @hawkeye126!

I updated the PR title so it's a bit more meaningful, and moved the reference to the related issue directly into the PR description, there is usually no need to have it in the title. 🙂

I will also proceed closing #1785 and #1796 because they are now superseded by this one.

@9ete
Copy link
Contributor Author

9ete commented Sep 26, 2021

Thanks @Aljullu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: styles Issues related to styling
Projects
None yet
2 participants