Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block splitting - Handle the case when the split occurs at the trailing or leading edge #176

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

daniloercoli
Copy link
Contributor

This PR adds handles the case when the split occurs at the trailing or leading edge of the field.

Testing:

  1. Put the cursor at the end of a para block and hit enter. It should add an empty block after the current.
  2. Put the cursor at the end of a para block and hit Enter. It should add a block after the current with all the content. Current block will be blank after.
  3. Put the cursor in the middle of a block, and hit Enter.

Note: there are some known issues with Heading blocks and validation. Will address that in another PR.

Companion PR:

Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Awesome work!

Two notes:

  • As mentioned by @daniloercoli, the heading blocks have some validation issues when switching to HTML and back.
  • The heading blocks don't work very well when splitting.
  • Blocks are not properly resized when split.

@diegoreymendez diegoreymendez merged commit abe118a into master Oct 18, 2018
@diegoreymendez diegoreymendez deleted the split-occurs-at-trailing-or-leading-edge branch October 18, 2018 15:14
@diegoreymendez
Copy link
Contributor

Related to #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants