Android Fix - cursor position - Return the exact location of the cursor in the editor #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the convertion to HTML code, that happens later and adds other content. The conversion back to RichText structure is done React side, so we need to know the exact location of the cursor without considering the additinoal content (HTML tags) added during the conversion.
diegoreymendez
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Couldn't test this thoroughly because the ENTER event is not wired in the example app in this repo, but considering this'll be integrated into gutenberg-mobile, we'll have a good opportunity to make sure it works fine.
At this time all I can say is the example App still works in both platforms.
diegoreymendez
deleted the
try/return-cursor-selection-absolute-position
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does return the exact location of the cursor without taking in consideration the conversion to HTML code, that happens later and adds other content.
So basically any additional tags like B, I, etc, are not considered when returning the cursor position.
Note: When used into Gutenberg Mobile, the conversion back to the RichText structure is done React side, so we need to know the exact location of the cursor without considering the additional content (HTML tags) added during the conversion.