Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Gutenberg reference to d0b6e6a #3306

Closed
wants to merge 5 commits into from
Closed

Bump Gutenberg reference to d0b6e6a #3306

wants to merge 5 commits into from

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 24, 2021 •
edited
Loading

This PR includes:

  • Bump Gutenberg reference to d0b6e6a
  • Update npm engine value in package.json to match the one from Gutenberg, NPM v7 is not yet supported.
  • Update package-lock.json file with recent changes from Gutenberg
  • Change the CircleCI workflow step that installs node, since we can't use NPM v7, now this installs the NPM version associated to node version specified by Gutenberg (current is 6.14.11)

To test:

  • Verify that the PR checks pass

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the dependencies Pull requests that update a dependency file label Mar 24, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 24, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot self-assigned this Mar 24, 2021
@fluiddot
Copy link
Contributor Author

⚠️ The iOS e2e tests spotted an incoming breakage related to the image block.

I've opened an issue and the PR that fixes it, once the changes are merged I'll update the Gutenberg reference and this PR.

@fluiddot
Copy link
Contributor Author

Closing this in favor of #3308.

@fluiddot fluiddot closed this Mar 24, 2021
@fluiddot fluiddot deleted the merge_gutenberg-d0b6e6a_to_develop branch March 24, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fluiddot fluiddot

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fluiddot