Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gutenberg reference to 5194cdb #3308

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 24, 2021

Bumps the Gutenberg reference to 5194cdb.

This PR includes three fixes that were required to include recent changes from Gutenberg repo:

  1. Disable NPM version 7 - Disable NPM version 7 #3307
  2. Fix: Size setting is not displayed - [RNMobile] Image block: Use image default size from settings WordPress/gutenberg#30186
  3. Update the package-lock.json file due to recent changes in gutenberg/package.json.

To test:
For testing this PR, verify first that the installed NPM version is version 6.x.

  1. Run npm install.
  2. Verify that the package-lock.json file remains unchanged.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the dependencies Pull requests that update a dependency file label Mar 24, 2021
@fluiddot fluiddot added this to the 1.50.0 (17.1) milestone Mar 24, 2021
@fluiddot fluiddot marked this pull request as ready for review March 24, 2021 15:05
@fluiddot fluiddot requested review from dcalhoun and guarani March 24, 2021 15:33
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The demo app runs successfully on the iOS simulator. The package-lock.json remains unchanged after npm install, aside from the wp-prettier change, which I believe is a completely separate issue.

wp-prettier-diff

@fluiddot
Copy link
Contributor Author

LGTM. The demo app runs successfully on the iOS simulator. The package-lock.json remains unchanged after npm install, aside from the wp-prettier change, which I believe is a completely separate issue.

wp-prettier-diff

I have this same issue from time to time, the way I usually fix it is by deleting all the node_modules folders and installing the dependencies again:

  1. rm -rf node_modules
  2. cd gutenberg && npm run distclean
  3. npm install [in gutenberg-mobile project folder]

Thank you very much for the review 🙇 !

@fluiddot fluiddot merged commit cd8ab74 into develop Mar 24, 2021
@fluiddot fluiddot deleted the dependency/bump-gutenberg-5194cdb branch March 24, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants