Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NPM version 7 #3307

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Disable NPM version 7 #3307

merged 3 commits into from
Mar 24, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 24, 2021

gutenberg PR: WordPress/gutenberg#30189

The Gutenberg project doesn't support NPM version 7 so we should disable this version in the Gutenberg-mobile too.

Two changes have been applied in this PR:

  1. Match npm engine value in the package.json file with Gutenberg's project one.
  2. Update the install node step in the CircleCI workflow so it doesn't enforce to install the latest NPM version.

To test:

  1. Verify that the PR checks pass.
  2. Verify that after doing the set up section in the README file, the NPM version installed is below v7.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Web breakage Caused by incompatible changes on Gutenberg web label Mar 24, 2021
@fluiddot fluiddot added this to the 1.50.0 (17.1) milestone Mar 24, 2021
@guarani guarani self-requested a review March 24, 2021 13:29
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks @fluiddot!

@fluiddot fluiddot merged commit f702415 into develop Mar 24, 2021
@fluiddot fluiddot deleted the fix/disable-npm-v7 branch March 24, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants