Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination fix for CPT-backed CRUD objects connections #36

Merged
merged 12 commits into from
Apr 24, 2019

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Apr 22, 2019

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • Product
    • update tests
  • ProductVariation
    • update tests
  • Coupon
    • update tests
  • Order
    • update tests
  • Refund
    • update tests

Does this close any currently open issues?

#29

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added enhancement New feature or request bugfix Implements bugfix labels Apr 22, 2019
@kidunot89 kidunot89 self-assigned this Apr 22, 2019
@kidunot89 kidunot89 requested a review from jasonbahl April 23, 2019 15:52
@kidunot89 kidunot89 added the work in progress Solution development in progress label Apr 24, 2019
@kidunot89 kidunot89 changed the title Pagination fix for CPT-backed CRUD objects Pagination fix for CPT-backed CRUD objects connections Apr 24, 2019
@kidunot89 kidunot89 merged commit 9cf724c into develop Apr 24, 2019
@kidunot89 kidunot89 mentioned this pull request Apr 25, 2019
@renatonascalves renatonascalves deleted the bugfix/cpt-pagination branch May 4, 2019 00:07
@kidunot89 kidunot89 removed the work in progress Solution development in progress label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant