[wpimath] Fix PIDController error tolerance getters #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
wpimath-fix-pid-controller-get-error-tolerance
branch
from
83e50f5 to
3cc4fe5
Compare
calcmogul
force-pushed
the
wpimath-fix-pid-controller-get-error-tolerance
branch
from
3cc4fe5 to
28bc05a
Compare
calcmogul
changed the title
sciencewhiz
approved these changes
Nov 4, 2024
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this pull request
Nov 5, 2024
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this pull request
Nov 5, 2024
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this pull request
Nov 5, 2024
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this pull request
Nov 5, 2024
calcmogul
added a commit
to calcmogul/allwpilib
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of the C++ getters added in #7088 weren't implemented correctly.