-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Go to Console
link from root organization actions and show a URL instead
#7490
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7490 +/- ##
=======================================
Coverage 41.98% 41.98%
=======================================
Files 42 42
Lines 936 936
Branches 214 214
=======================================
Hits 393 393
Misses 543 543
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
||
&.Mui-readOnly { | ||
cursor: default; | ||
background-color: #e9ecef!important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we use a SCSS variable for the color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporarily thing that needs to be fixed with Oxygen UI.
We should not encourage to re-use a variable. So, lets link and issue here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of removing the impl., shall we hide/disable the feature so that it can be enabled once the cookie issues are fixed?
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
An issue is created to restore the link once the backend problems are resolved. The above backend issue might take some time to implement, so its better to not keep stale code if we can't immediately bring them back. Mainly since Console is a quite large application and a single line of code takes Bites from the bundle. |
Purpose
There are issues in having a
Go to Console
link and we can't properly workaround this without first resolving wso2/product-is#22615This pull request focuses on removing the
Go to Console
link from root organization actions and replacing it with a URL display. The changes span multiple files and include updates to components, hooks, context, styles, and i18n translations. Here are the most important changes:Removal of
Go to Console
link:features/admin.tenants.v1/components/tenant-card.tsx
: Removed thenavigateToTenantConsole
function and related UI elements. [1] [2]features/admin.tenants.v1/context/tenant-context.tsx
: Removed thenavigateToTenantConsole
function from the context. [1] [2]features/admin.tenants.v1/providers/tenant-provider.tsx
: Removed the logic and state related to tenant console navigation. [1] [2] [3] [4] [5]Addition of URL display for console:
features/admin.tenants.v1/hooks/use-tenant-console-url.ts
: Added a new hook to generate the console URL for a given tenant.features/admin.tenants.v1/pages/edit-tenant-page.tsx
: Updated the edit tenant page to display the console URL with a copy button. [1] [2] [3] [4] [5]features/admin.tenants.v1/pages/edit-tenant-page.scss
: Added styles for the console URL display.i18n updates:
modules/i18n/src/models/namespaces/tenants-ns.ts
: RemovednavigatingToTenantConsole
translations and added translations for the console URL. [1] [2]modules/i18n/src/translations/en-US/portals/tenants.ts
: Updated the English translations to reflect the removal ofGo to Console
and addition of console URL.Documentation and metadata:
.changeset/fast-nails-nail.md
: Documented the removal of theGo to Console
link and the reason behind it.Related Issues
Related PRs
Checklist
Security checks