Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go to Console link from root organization actions and show a URL instead #7490

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Feb 3, 2025

Purpose

There are issues in having a Go to Console link and we can't properly workaround this without first resolving wso2/product-is#22615

This pull request focuses on removing the Go to Console link from root organization actions and replacing it with a URL display. The changes span multiple files and include updates to components, hooks, context, styles, and i18n translations. Here are the most important changes:

Removal of Go to Console link:

Addition of URL display for console:

i18n updates:

Documentation and metadata:

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (f7338ef) to head (91f48a3).
Report is 89 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7490   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          42       42           
  Lines         936      936           
  Branches      214      214           
=======================================
  Hits          393      393           
  Misses        543      543           
Flag Coverage Δ
@wso2is/core 41.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


&.Mui-readOnly {
cursor: default;
background-color: #e9ecef!important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we use a SCSS variable for the color?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporarily thing that needs to be fixed with Oxygen UI.
We should not encourage to re-use a variable. So, lets link and issue here instead.

pavinduLakshan
pavinduLakshan previously approved these changes Feb 3, 2025
Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removing the impl., shall we hide/disable the feature so that it can be enabled once the cookie issues are fixed?

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario
Copy link
Member Author

instead of removing the impl., shall we hide/disable the feature so that it can be enabled once the cookie issues are fixed?

An issue is created to restore the link once the backend problems are resolved.

The above backend issue might take some time to implement, so its better to not keep stale code if we can't immediately bring them back.

Mainly since Console is a quite large application and a single line of code takes Bites from the bundle.

@brionmario brionmario merged commit 753f1bf into wso2:master Feb 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants