add bounds property #214
Merged
add bounds property #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 96.27% 96.32% +0.04%
==========================================
Files 12 12
Lines 1505 1525 +20
==========================================
+ Hits 1449 1469 +20
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I think we can raise an error for it's pretty easy to just do The current repr is fine IMO. We can update is someone complains |
malmans2
commented
Apr 22, 2021
dcherian
added a commit
to jukent/cf-xarray
that referenced
this pull request
Jun 8, 2021
* main: (57 commits) Add CITATION.cff, tributors, zenodo.json (xarray-contrib#231) Add zenodo badge Improve `rename_like` (xarray-contrib#222) Don't apply mappers to DataArrays (xarray-contrib#227) Add unit support to cf-xarray (xarray-contrib#197) Update README.rst Add earthcube 2021 notebook link to readme v0.5.2 Some CMIP6 support Add pooch to binder environment (xarray-contrib#223) `add_bounds` uses `keys` rather than `dims` (xarray-contrib#221) Add .cf.formula_terms (xarray-contrib#213) Update whats-new.rst (xarray-contrib#217) add bounds property (xarray-contrib#214) Update some tests. Compile regexes Fix black Add __version__ (xarray-contrib#208) add skip to rename_like (xarray-contrib#206) Refactor out coordinate criteria to criteria.py (xarray-contrib#205) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
Closes #215
What should we do with DataArrays, where we can't have bounds because of the extra dimension?
Currently nothing specific is done. For example, when we extract a
DataArrayfrom aDataset,da.cf.boundsis not empty, as we don't pop theboundsattribute from the coordinates. However,da.cf.__repr__showsBounds: n/aas the bounds variables are not present.Should
cf.boundsonly include variables present in the object (and warn about missing bounds)?Should
cf.boundsbe a property ofDatasetsonly?Should we pop the
boundsattribute from coordinates when extracting aDataArray?Should we only show
Boundsin the representation of Datasets?