Don't apply mappers to DataArrays #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 96.45% 96.34% -0.12%
==========================================
Files 14 14
Lines 1609 1614 +5
==========================================
+ Hits 1552 1555 +3
- Misses 57 59 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
malmans2
commented
May 22, 2021
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "xr.set_options(keep_attrs=True)" |
There was a problem hiding this comment.
Looks like we've been running the intro notebook without xr.set_options(keep_attrs=True).
I don't think the issue without it was triggered by this PR, but I might be wrong.
Anyways, I think we should keep attributes and maybe re-discuss #77?
malmans2
changed the title
dcherian
reviewed
May 26, 2021
malmans2
commented
May 27, 2021
malmans2
commented
May 27, 2021
Merged
|
Thanks @malmans2 let's try it! |
dcherian
added a commit
to jukent/cf-xarray
that referenced
this pull request
Jun 8, 2021
* main: (57 commits) Add CITATION.cff, tributors, zenodo.json (xarray-contrib#231) Add zenodo badge Improve `rename_like` (xarray-contrib#222) Don't apply mappers to DataArrays (xarray-contrib#227) Add unit support to cf-xarray (xarray-contrib#197) Update README.rst Add earthcube 2021 notebook link to readme v0.5.2 Some CMIP6 support Add pooch to binder environment (xarray-contrib#223) `add_bounds` uses `keys` rather than `dims` (xarray-contrib#221) Add .cf.formula_terms (xarray-contrib#213) Update whats-new.rst (xarray-contrib#217) add bounds property (xarray-contrib#214) Update some tests. Compile regexes Fix black Add __version__ (xarray-contrib#208) add skip to rename_like (xarray-contrib#206) Refactor out coordinate criteria to criteria.py (xarray-contrib#205) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226