Apple tvOS: Fix typo in flag #5372
Conversation
Flag is "mappletv-simulator-version-min" not "mappletvsimulator-version-min"
| @@ -30,7 +30,7 @@ function main(toolchain) | |||
|
|
|||
| -- init target minimal version | |||
| local target_minver = toolchain:config("target_minver") | |||
| local target_minver_flags = (simulator and "-mappletv-simulator-version-min=" or "-mappletvos-version-min=") .. target_minver | |||
| local target_minver_flags = (simulator and "-mappletvsimulator-version-min=" or "-mappletvos-version-min=") .. target_minver | |||
There was a problem hiding this comment.
Flag is "-mappletv-simulator-version-min" not "-mappletvsimulator-version-min"
? not "-mappletvsimulator-version-min"? But it was set.
There was a problem hiding this comment.
@corentin35000 had the error
error: clang: error: unknown argument '-mappletv-simulator-version-min=17.0'; did you mean '-mappletvsimulator-version-min=17.0'?
and I found no reference to -mappletv-simulator-version-min (the one xmake sets) on the web, looks like a typo
There was a problem hiding this comment.
Yes, I did! I also had this case for the appletvos sdk, I have the impression that internally xmake uses the appletvsimulator flag
There was a problem hiding this comment.
I got this error for appletvos and appletvsimulator: error: clang: error: unknown argument '-mappletv-simulator-version-min=17.0'; did you mean '-mappletvsimulator-version-min=17.0'?
There was a problem hiding this comment.
I feel like there are two problems
Flag is "-mappletv-simulator-version-min" not "-mappletvsimulator-version-min"