Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple tvOS: Fix typo in flag #5372

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Apple tvOS: Fix typo in flag #5372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xmake/toolchains/xcode/load_appletvos.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function main(toolchain)

-- init target minimal version
local target_minver = toolchain:config("target_minver")
local target_minver_flags = (simulator and "-mappletv-simulator-version-min=" or "-mappletvos-version-min=") .. target_minver
local target_minver_flags = (simulator and "-mappletvsimulator-version-min=" or "-mappletvos-version-min=") .. target_minver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag is "-mappletv-simulator-version-min" not "-mappletvsimulator-version-min"

? not "-mappletvsimulator-version-min"? But it was set.

Copy link
Member Author

@SirLynix SirLynix Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corentin35000 had the error

error: clang: error: unknown argument '-mappletv-simulator-version-min=17.0'; did you mean '-mappletvsimulator-version-min=17.0'?

and I found no reference to -mappletv-simulator-version-min (the one xmake sets) on the web, looks like a typo

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did! I also had this case for the appletvos sdk, I have the impression that internally xmake uses the appletvsimulator flag

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this error for appletvos and appletvsimulator: error: clang: error: unknown argument '-mappletv-simulator-version-min=17.0'; did you mean '-mappletvsimulator-version-min=17.0'?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there are two problems


-- init flags for c/c++
toolchain:add("cxflags", "-arch", arch, target_minver_flags, "-isysroot", xcode_sysroot)
Expand Down
Loading