Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if ?nested isn't supported then import or create() with children can never be supported #220

Closed
duglin opened this issue Dec 23, 2024 · 1 comment · Fixed by #235
Closed
Labels
AddToSpec Done v1 Required to be resolved for v1

Comments

@duglin
Copy link
Contributor

duglin commented Dec 23, 2024

Whether this is an issue or not depends on whether we think people can't support query parameters but still want to support uploading children? For example a non-code server - ala S3. However, in those cases I wonder if those are read-only servers, or the "write" path (if any) is via the native S3 interfaces instead.

So, the question is... do we want to support "import" w/o requiring ?nested ? Or do we think the "are you sure?" check is unnecessary even if they can support query parameters?

Options:
1 - keep it as is
2 - drop ?nested and let the presence of the children be good enough - remove "are you sure?" check
3 - add a /import API that implies ?nested, similar to how /export implies ?inline=*

@duglin duglin added the v1 Required to be resolved for v1 label Dec 23, 2024
@duglin duglin changed the title if ?nested isn't support then import or create() with children can never be supported if ?nested isn't supported then import or create() with children can never be supported Jan 10, 2025
@duglin
Copy link
Contributor Author

duglin commented Jan 15, 2025

On 1/15 call - drop ?nested

duglin added a commit to duglin/xreg-spec that referenced this issue Jan 15, 2025
- typo and wording clarifications in main spec
- remove duplicate "compatibility" in schema, it's part of core attributes now
- replaced `?export` with `?compact` and just removes the dup info. Any
  inlining would need to be requested by the client
- defined `/export` to be `/?compact&inline=*,model,capabilities`
- remove ?nested
- tweaks valid chars for ID: `[a-zA-Z0-9_][a-zA-Z0-9_.\-~@]{0,127}`
- IDs must be no longer than 128 chars
- s/$structure/$details/g

Fixes: xregistry#234
Fixes: xregistry#233
Fixes: xregistry#232
Fixes: xregistry#220
Fixes: xregistry#229
Fixes: xregistry#224
Fixes: xregistry#237

Signed-off-by: Doug Davis <[email protected]>
@duglin duglin closed this as completed in 4a92f34 Jan 16, 2025
Fannon pushed a commit to Fannon/xregistry that referenced this issue Jan 23, 2025
- typo and wording clarifications in main spec
- remove duplicate "compatibility" in schema, it's part of core attributes now
- replaced `?export` with `?compact` and just removes the dup info. Any
  inlining would need to be requested by the client
- defined `/export` to be `/?compact&inline=*,model,capabilities`
- remove ?nested
- tweaks valid chars for ID: `[a-zA-Z0-9_][a-zA-Z0-9_.\-~@]{0,127}`
- IDs must be no longer than 128 chars
- s/$structure/$details/g

Fixes: xregistry#234
Fixes: xregistry#233
Fixes: xregistry#232
Fixes: xregistry#220
Fixes: xregistry#229
Fixes: xregistry#224
Fixes: xregistry#237

Signed-off-by: Doug Davis <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AddToSpec Done v1 Required to be resolved for v1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant