Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename $structure #237

Closed
duglin opened this issue Jan 15, 2025 · 2 comments · Fixed by #235
Closed

rename $structure #237

duglin opened this issue Jan 15, 2025 · 2 comments · Fixed by #235
Labels
AddToSpec Done v1 Required to be resolved for v1

Comments

@duglin
Copy link
Contributor

duglin commented Jan 15, 2025 •
edited
Loading

Some options that come to mind:

.../myschema.json$structure
.../myschema.json$info
.../myschema.json$details
.../myschema.json$deets
.../myschema.json$full
.../myschema.json$raw
.../myschema.json$data
.../myschema.json$embedded
.../myschema.json$json     <- "give me all of the data as a single json object"
@duglin duglin added the v1 Required to be resolved for v1 label Jan 15, 2025
@duglin
Copy link
Contributor Author

duglin commented Jan 15, 2025

Proposal: $details

@duglin
Copy link
Contributor Author

duglin commented Jan 15, 2025

1/15: agreed to "details"

duglin added a commit to duglin/xreg-spec that referenced this issue Jan 15, 2025
@duglin
Changes for week of Jan13
40a6612 
- typo and wording clarifications in main spec
- remove duplicate "compatibility" in schema, it's part of core attributes now
- replaced `?export` with `?compact` and just removes the dup info. Any
  inlining would need to be requested by the client
- defined `/export` to be `/?compact&inline=*,model,capabilities`
- remove ?nested
- tweaks valid chars for ID: `[a-zA-Z0-9_][a-zA-Z0-9_.\-~@]{0,127}`
- IDs must be no longer than 128 chars
- s/$structure/$details/g

Fixes: xregistry#234
Fixes: xregistry#233
Fixes: xregistry#232
Fixes: xregistry#220
Fixes: xregistry#229
Fixes: xregistry#224
Fixes: xregistry#237

Signed-off-by: Doug Davis <[email protected]>
@duglin duglin added the Done label Jan 15, 2025
@duglin duglin mentioned this issue Jan 16, 2025
Merged
@duglin duglin closed this as completed in 4a92f34 Jan 16, 2025
Fannon pushed a commit to Fannon/xregistry that referenced this issue Jan 23, 2025
@duglin @Fannon
Changes for week of Jan13
19355b0 
- typo and wording clarifications in main spec
- remove duplicate "compatibility" in schema, it's part of core attributes now
- replaced `?export` with `?compact` and just removes the dup info. Any
  inlining would need to be requested by the client
- defined `/export` to be `/?compact&inline=*,model,capabilities`
- remove ?nested
- tweaks valid chars for ID: `[a-zA-Z0-9_][a-zA-Z0-9_.\-~@]{0,127}`
- IDs must be no longer than 128 chars
- s/$structure/$details/g

Fixes: xregistry#234
Fixes: xregistry#233
Fixes: xregistry#232
Fixes: xregistry#220
Fixes: xregistry#229
Fixes: xregistry#224
Fixes: xregistry#237

Signed-off-by: Doug Davis <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AddToSpec Done v1 Required to be resolved for v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes for week of Jan13 duglin/xreg-spec
1 participant
@duglin