Merge pull request #3899 from Tyriar/3898

Fix allowTransparency not working when set after ctor
xtermjs · Jul 11, 2022 · 685822d · 685822d
2 parents c26f605 + e2b8002
commit 685822d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/browser/ColorManager.ts b/src/browser/ColorManager.ts
@@ -111,9 +111,14 @@ export class ColorManager implements IColorManager {
     this._updateRestoreColors();
   }
 
-  public onOptionsChange(key: string): void {
-    if (key === 'minimumContrastRatio') {
-      this._contrastCache.clear();
+  public onOptionsChange(key: string, value: any): void {
+    switch (key) {
+      case 'minimumContrastRatio':
+        this._contrastCache.clear();
+        break;
+      case 'allowTransparency':
+        this.allowTransparency = value;
+        break;
     }
   }
 

diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts
@@ -517,7 +517,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
 
     this._theme = this.options.theme || this._theme;
     this._colorManager = new ColorManager(document, this.options.allowTransparency);
-    this.register(this.optionsService.onOptionChange(e => this._colorManager!.onOptionsChange(e)));
+    this.register(this.optionsService.onOptionChange(e => this._colorManager!.onOptionsChange(e, this.optionsService.rawOptions[e])));
     this._colorManager.setTheme(this._theme);
 
     this._characterJoinerService = this._instantiationService.createInstance(CharacterJoinerService);

diff --git a/src/browser/Types.d.ts b/src/browser/Types.d.ts
@@ -110,7 +110,7 @@ export interface IBrowser {
 
 export interface IColorManager {
   colors: IColorSet;
-  onOptionsChange(key: string): void;
+  onOptionsChange(key: string, value: any): void;
 }
 
 export interface IColorSet {