Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allowTransparency not working when set after ctor #3899

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix allowTransparency not working when set after ctor #3899

merged 1 commit into from
Jul 11, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 10, 2022

Fixes #3898

@Tyriar Tyriar added this to the 4.20.0 milestone Jul 10, 2022
@Tyriar Tyriar requested a review from meganrogge July 10, 2022 15:53
@Tyriar Tyriar self-assigned this Jul 10, 2022
@Tyriar Tyriar changed the title Fix allowTransparent not working when set after ctor Fix allowTransparency not working when set after ctor Jul 10, 2022
@Tyriar Tyriar merged commit 685822d into xtermjs:master Jul 11, 2022
@Tyriar Tyriar deleted the 3898 branch July 11, 2022 18:43
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

allowTransparency only works when set in the Terminal ctor
2 participants
@Tyriar @meganrogge