Renderer._needsFullRefresh is never reset to false #1975
Comments
|
It looks like _needsFullRefresh does need to get reset after the refresh happens (as a full refresh has occurred). |
|
PR is out to fix it, I don't think this would fix eclipse-theia/theia#3838 though? The bug seems to be that once a full refresh occurs, every time an unpause happens a full refresh happens, even if it's not needed. |
Tyriar
added a commit
to microsoft/xterm.js
that referenced
this issue
Mar 23, 2019
|
We just need to upgrade xterm, in our version not most recent intersection observer entry is used. 69d3a46 fixes the issue |
|
@akosyakov makes sense, and thanks for finding the bug 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am debugging eclipse-theia/theia#3838 and noticed that on first drag _isPaused set to true, on second
_needsFullRefreshis also true, so no refresh happens. Afterwards it does not matter what user is doing values of_isPausedand_needsFullRefreshdon't get changed. Is it on purpose or_needsFullRefreshshould be reset to false inonIntersectionChange? Should we call something else to force refresh after reattaching xterm from one parent to another?The text was updated successfully, but these errors were encountered: