Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ligatures addon should deregister character joiners on dispose #3289

Closed
Tyriar opened this issue Apr 2, 2021 · 4 comments
Closed

Ligatures addon should deregister character joiners on dispose #3289

Tyriar opened this issue Apr 2, 2021 · 4 comments
Assignees
@Tyriar
Labels
area/addon/ligatures type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 2, 2021

No description provided.

@Tyriar Tyriar added type/bug Something is misbehaving area/addon/ligatures labels Apr 2, 2021
@Tyriar Tyriar added this to the 4.12.0 milestone Apr 2, 2021
@Tyriar Tyriar self-assigned this Apr 2, 2021
Tyriar added a commit to microsoft/vscode that referenced this issue Apr 2, 2021
@Tyriar
Add ligatures setting
36b1761 
Can't disable without reload right now due to xtermjs/xterm.js#3289
@Tyriar
Copy link
Member Author

Tyriar commented May 5, 2021

We probably won't be adopting ligatures in VS Code for at least the next month, so pushing this.

@Tyriar Tyriar modified the milestones: 4.12.0, 4.13.0 May 5, 2021
@Tyriar Tyriar modified the milestones: 4.13.0, 4.14.0 Jun 24, 2021
@Tyriar Tyriar removed this from the 4.14.0 milestone Sep 1, 2021
@SquitchYT
Copy link
Contributor

Any update about this ?

@Tyriar
Copy link
Member Author

Tyriar commented Feb 26, 2022

I tried in VS Code and ran into other issues so this was put on hold on my end microsoft/vscode#139537

@Tyriar
Copy link
Member Author

Tyriar commented Aug 3, 2022

This is done for v5

@Tyriar Tyriar closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/ligatures type/bug Something is misbehaving
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @SquitchYT