Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowTransparency only works when set in the Terminal ctor #3898

Closed
Tyriar opened this issue Jul 10, 2022 · 0 comments · Fixed by #3899
Closed

allowTransparency only works when set in the Terminal ctor #3898

Tyriar opened this issue Jul 10, 2022 · 0 comments · Fixed by #3899
Labels
type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 10, 2022

Repro:

  1. Open demo
  2. Check allowTransparency
  3. Run:
term.setOption('theme', {
	background: '#ff000080',
});

Results in warning:

Color: #ff000080 is using transparency, but allowTransparency is false. Using fallback #000000.
@Tyriar Tyriar added the type/bug Something is misbehaving label Jul 10, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar
Fix allowTransparent not working when set after ctor
1bee053 
Fixes xtermjs#3898
@Tyriar Tyriar mentioned this issue Jul 10, 2022
Merged
@Tyriar Tyriar changed the title allowTransparent only works when set in the Terminal ctor allowTransparency only works when set in the Terminal ctor Jul 10, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar
Fix allowTransparency not working when set after ctor
e2b8002 
Fixes xtermjs#3898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix allowTransparency not working when set after ctor Tyriar/xterm.js
1 participant
@Tyriar