fix(core)!: devirtualize descriptor in tryWorkspaceByDescriptor #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larixer
pushed a commit
that referenced
this pull request
Apr 7, 2021
arcanis
added a commit
that referenced
this pull request
May 16, 2021
…talls (#2688) * Fixes external soft links detection in case when they use peer deps * Ignores self-references during compatibility checks * Run compatiblity checks on real locators * Take into account cases when resovleVirtual does not work * Adds `nmHardlinks` config option to utilize hardlinks for duplicatee locations * Adds nmHardlinks integration test * Fixes nmHoistingLimits for portals * Chore: remove unused readFile import * Chorre: run version check * Update cond * Removes extra version file * Add a test to check that hoisting limits do not break portals * Implements hoistability check for the case when multiple portal targets sued from the same parent * Small cleanups * Return back relativeDepCwd * Simplifies handling of nmHardlinks option change across installs * Checks if dependency is actually reachable * fix(node-modules): prefer binaries from calling workspace (#2703) * Prefer bin in calling workspace * Add integration test * Bump versions * Update test * fix(docs): fix typos for the YN0004 error code (#2706) * fix(core): handle escaped slash after scope in LegacyMigrationResolver (#2696) * docs: remove yarnUpgradePath (#2690) * fix(dlx): only set enableGlobalCache to true if it's false in the project (#2677) * fix(core): devirtualize descriptor in tryWorkspaceByDescriptor (#2675) * perf(pnp): optimize `findPackageLocator` (#2673) * perf(pnp): optimize findPackageLocator * chore: versions * Bumps TypeScript (#2676) * Bumps TypeScript * Fixes sdk * Improved http errors (reportExtra) (#2707) * Improves http errors * Improves the http errors * Fixes package.json * Fixes tests * Fixes imports * Removes invalid grammar line * Rename nmHardlinks -> nmMode * Implements getting crc for files inside archives * Reduces node_modules size in hardlinks mode due to linking files having same content * Makes .yarn-state.yml deterministic for the hardlinks mode * Fixes condition to update hash * Removes CAS code for now * Adds basic support for local and global CAS * Uses sha1 for hashing CAS * Uses CAS only in global mode * Fixes strange type errors * Safe CAS files writing * Implements faster repetitive CAS * Speed ups cold CAS by combining checksuming and file reading from archives * Removes cas directory on `yarn cache clean --mirror` * Adds integration test for nmMode: cas * Add workarounds description for YN0071 * Refactors copyFilePromise into separate function * Simplifies directory copying implementation by decoupling entry reading code * Speedups a bit cold and hot CAS * Uses hardlinks for benchmarks * Autorecovers CAS store files with wrong checksums on install * Adds test to check that store is recovered on reinstall * Uses the same chmod optimization both for CAS and non-CAS modes * Fixes bin symlinks chmodding * Merges with latest masterr * Renames hardlinks -> hardlinks-local, cas -> hardlinks-global * getCasDirectory -> getGlobalHardlinksDirectory * globalHardlinksDirectory -> globalHardlinksStore * More intelligent store recovery * Do not check for file existence in atomicFileWrite * Splits files in the storage to mitigate possible negative effects of directories with extra large number of files Co-authored-by: Ali Zeaiter <[email protected]> Co-authored-by: Ian Kerins <[email protected]> Co-authored-by: Kristoffer K <[email protected]> Co-authored-by: Maël Nison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Project.tryWorkspaceByDescriptordoesn't match on virtual descriptors which is unexpected astryWorkspaceByLocatordoesExtracted from #2338
How did you fix it?
Make
tryWorkspaceByDescriptordevirtualize the descriptor before checking if it matches a workspaceChecklist