fix(pnp): handle require.resolve('pnpapi')
with exports correctly
#3495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When using PnP, calling
require.resolve('pnpapi')
tries to apply the exports resolution on the pnpapi path, either remapping it if there's a".pnp.cjs": "./whatever.js"
export (which is wrong) or throwing if there isn't such an export.We originally considered this in #2431 (comment) but thought it wasn't a problem, even though it actually is - the
unqualifiedPath
is the one that gets resolved to a path inresolveUnqualifiedExport
, not therequest
.Fixes #3493.
How did you fix it?
Special-cased
pnpapi
inresolveRequest
with an early return.Checklist