forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ResponseOps] Hyperlinks in Slack messages are broken when there is "…
…_" or "*" in the URL (elastic#170067) Resolves elastic#165673 ## Summary `escapeSlack` function in the mustasche_renderer breakes the hyperlinks by wrapping the URL with backticks. So the below markdown template does not work. `<{{context.alertDetailsUrl}}|View alert details>` This PR removes the code that adds backticks. With this change action variables with text wrapped in asterisks \*text\* will render as **text** or wrapped in underscores \_text\_ will render as _text_ . ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### To verify - Create a slack connector - Create a rule that uses a slack connector and use the above markdown template - Verify that hyperlink is working properly in slack
- Loading branch information
Showing
4 changed files
with
14 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters