feat(server): include callback for when the server is ready + fix bugs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes [PLT-134]
pkg/common/server/server.go
Outdated
Comment on lines
53
to
64
|
|
||
| c := make(chan os.Signal, 3) | ||
| signal.Notify(c, os.Interrupt, syscall.SIGTERM) | ||
| <-c | ||
|
|
||
| s.logger.Infof("Shutdown Server ...") | ||
|
|
||
| if err := s.httpServer.Shutdown(ctx); err != nil { | ||
| s.logger.Fatal("Server forced to shutdown: ", err) | ||
| } | ||
|
|
||
| s.logger.Infof("Server exiting") |
There was a problem hiding this comment.
Good, that's a dead code because s.httpServer.ListenAndServe() blocks the execution.
renatoaguimaraes
suggested changes
Jan 10, 2022
portellaa
reviewed
Jan 10, 2022
that's it or create requests to check if it's ready... |
Maybe a GET operation on /readyz endpoint is better to know if the server is initialized. What do you think? |
portellaa
approved these changes
Jan 11, 2022
renatoaguimaraes
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes PLT-134