Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-3722 RD fixed verify failed on empty fields #10351

Merged
merged 2 commits into from
Oct 14, 2024
Merged

YQ-3722 RD fixed verify failed on empty fields #10351

merged 2 commits into from
Oct 14, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Oct 11, 2024 •
edited
Loading

Changelog entry

Fixed verify failed on empty fields

Changelog category

  • Bugfix

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner October 11, 2024 14:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 14:51:58 UTC Pre-commit check linux-x86_64-release-asan for 5a70dea has started.
⚪ 2024-10-11 14:52:27 UTC Artifacts will be uploaded here
⚫ 2024-10-11 14:55:23 UTC Check cancelled

@GrigoriyPA GrigoriyPA requested a review from kardymonds October 11, 2024 14:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 14:54:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5a70dea has started.
⚪ 2024-10-11 14:54:56 UTC Artifacts will be uploaded here
⚫ 2024-10-11 14:55:23 UTC Check cancelled

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Oct 11, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 11, 2024
kardymonds
kardymonds previously approved these changes Oct 11, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 14:59:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6fab42e has started.
⚪ 2024-10-11 14:59:31 UTC Artifacts will be uploaded here
⚪ 2024-10-11 15:02:26 UTC ya make is running...
⚫ 2024-10-11 15:06:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 14:59:37 UTC Pre-commit check linux-x86_64-release-asan for 6fab42e has started.
⚪ 2024-10-11 14:59:48 UTC Artifacts will be uploaded here
⚪ 2024-10-11 15:02:47 UTC ya make is running...
⚫ 2024-10-11 15:06:38 UTC Check cancelled

@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Oct 11, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 15:08:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6fab42e has started.
⚪ 2024-10-11 15:08:30 UTC Artifacts will be uploaded here
⚪ 2024-10-11 15:11:22 UTC ya make is running...
🟡 2024-10-11 16:04:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39732 34156 0 3 5469 104

🟢 2024-10-11 16:07:13 UTC ydbd size 2.8 GiB changed* by +16.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: edc1471 merge: 6fab42e diff diff %
ydbd size 3 013 796 912 Bytes 3 013 813 512 Bytes +16.2 KiB +0.001%
ydbd stripped size 477 822 136 Bytes 477 827 896 Bytes +5.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-10-11 16:07:15 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 15:10:42 UTC Pre-commit check linux-x86_64-release-asan for 6fab42e has started.
⚪ 2024-10-11 15:10:53 UTC Artifacts will be uploaded here
⚪ 2024-10-11 15:13:43 UTC ya make is running...
⚫ 2024-10-11 16:06:58 UTC Check cancelled

@GrigoriyPA GrigoriyPA force-pushed the YQ-RD-fix-fault-on-empty-fields branch from 22eb9b3 to 943f055 Compare October 11, 2024 16:06
@GrigoriyPA GrigoriyPA requested a review from kardymonds October 11, 2024 16:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 16:09:47 UTC Pre-commit check linux-x86_64-release-asan for 723085a has started.
⚪ 2024-10-11 16:09:58 UTC Artifacts will be uploaded here
⚪ 2024-10-11 16:12:50 UTC ya make is running...
🟡 2024-10-11 17:34:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10213 9978 0 81 53 101

🟢 2024-10-11 17:35:45 UTC Build successful.
🟢 2024-10-11 17:36:20 UTC ydbd size 5.7 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38747d7 merge: 723085a diff diff %
ydbd size 6 107 671 224 Bytes 6 107 671 112 Bytes -112 Bytes -0.000%
ydbd stripped size 1 521 864 880 Bytes 1 521 864 752 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

⚪ 2024-10-11 16:10:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 723085a has started.
⚪ 2024-10-11 16:10:18 UTC Artifacts will be uploaded here
⚪ 2024-10-11 16:13:09 UTC ya make is running...
🟡 2024-10-11 17:07:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39731 34150 0 5 5469 107

⚪ 2024-10-11 17:11:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-11 17:22:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 10 0 0 0 99

🟢 2024-10-11 17:22:43 UTC Build successful.
🟢 2024-10-11 17:23:02 UTC ydbd size 2.8 GiB changed* by -544 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38747d7 merge: 723085a diff diff %
ydbd size 3 013 841 336 Bytes 3 013 840 792 Bytes -544 Bytes -0.000%
ydbd stripped size 477 827 960 Bytes 477 827 768 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit a268c7d into ydb-platform:main Oct 14, 2024
10 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-RD-fix-fault-on-empty-fields branch October 14, 2024 07:07
This was referenced Oct 14, 2024
Merged
Merged
kardymonds pushed a commit to kardymonds/ydb that referenced this pull request Oct 16, 2024
@GrigoriyPA @kardymonds
YQ-3722 RD fixed verify failed on empty fields (ydb-platform#10351)
8c251d8
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 18, 2024
Merged
This was referenced Oct 21, 2024
Merged
Merged
This was referenced Oct 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kardymonds kardymonds kardymonds approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrigoriyPA @kardymonds @maximyurchuk