Improve tx defer #10507

nikvas0 · 2024-10-16T12:24:10Z

Changelog entry

Now we won't immediately flush all following changes after first uncommitted changes read.

Changelog category

Improvement

Additional information

...

github-actions · 2024-10-16T12:27:27Z

⚪ 2024-10-16 12:27:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7a20392 has started.
⚪ 2024-10-16 12:27:38 UTC Artifacts will be uploaded here
⚪ 2024-10-16 12:30:39 UTC ya make is running...
🟡 2024-10-16 13:27:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40271	34671	0	16	5480	104

⚪ 2024-10-16 13:31:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-16 13:43:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
119 (only retried tests)	3	0	16	0	100

⚪ 2024-10-16 13:43:08 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-16 13:54:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
116 (only retried tests)	0	0	16	0	100

🟢 2024-10-16 13:54:53 UTC Build successful.
🟢 2024-10-16 13:55:15 UTC ydbd size 2.8 GiB changed* by +35.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `030f818`	merge: `7a20392`	diff	diff %
ydbd size	3 010 928 160 Bytes	3 010 964 808 Bytes	+35.8 KiB	+0.001%
ydbd stripped size	477 553 432 Bytes	477 557 912 Bytes	+4.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-16T12:30:40Z

⚪ 2024-10-16 12:30:39 UTC Pre-commit check linux-x86_64-release-asan for 7a20392 has started.
⚪ 2024-10-16 12:30:51 UTC Artifacts will be uploaded here
⚪ 2024-10-16 12:33:48 UTC ya make is running...
🟡 2024-10-16 13:57:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10516	10272	0	76	55	113

🟢 2024-10-16 13:58:06 UTC Build successful.
🟢 2024-10-16 13:58:40 UTC ydbd size 5.7 GiB changed* by +89.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `030f818`	merge: `7a20392`	diff	diff %
ydbd size	6 099 890 304 Bytes	6 099 981 840 Bytes	+89.4 KiB	+0.002%
ydbd stripped size	1 521 081 712 Bytes	1 521 098 928 Bytes	+16.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-17T08:57:51Z

⚪ 2024-10-17 08:57:50 UTC Pre-commit check linux-x86_64-release-asan for 739f05f has started.
⚪ 2024-10-17 08:58:01 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:01:00 UTC ya make is running...
⚫ 2024-10-17 09:06:20 UTC Check cancelled

github-actions · 2024-10-17T08:58:04Z

⚪ 2024-10-17 08:58:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 739f05f has started.
⚪ 2024-10-17 08:58:15 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:01:16 UTC ya make is running...
⚫ 2024-10-17 09:06:21 UTC Check cancelled

github-actions · 2024-10-17T09:08:05Z

⚪ 2024-10-17 09:08:05 UTC Pre-commit check linux-x86_64-release-asan for dc3c5f4 has started.
⚪ 2024-10-17 09:08:16 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:11:23 UTC ya make is running...
🔴 2024-10-17 09:17:28 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-10-17T09:12:03Z

⚪ 2024-10-17 09:12:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc3c5f4 has started.
⚪ 2024-10-17 09:12:13 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:15:10 UTC ya make is running...
🔴 2024-10-17 09:19:18 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-10-17T09:31:10Z

⚪ 2024-10-17 09:31:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 552652b has started.
⚪ 2024-10-17 09:31:19 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:34:17 UTC ya make is running...
⚫ 2024-10-17 09:35:49 UTC Check cancelled

github-actions · 2024-10-17T09:31:52Z

⚪ 2024-10-17 09:31:51 UTC Pre-commit check linux-x86_64-release-asan for 552652b has started.
⚪ 2024-10-17 09:32:02 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:35:06 UTC ya make is running...
⚫ 2024-10-17 09:35:48 UTC Check cancelled

github-actions · 2024-10-17T09:37:26Z

⚪ 2024-10-17 09:37:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for dd2981a has started.
⚪ 2024-10-17 09:37:37 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:40:36 UTC ya make is running...
⚫ 2024-10-17 09:46:23 UTC Check cancelled

github-actions · 2024-10-17T09:38:31Z

⚪ 2024-10-17 09:38:31 UTC Pre-commit check linux-x86_64-release-asan for dd2981a has started.
⚪ 2024-10-17 09:38:42 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:41:40 UTC ya make is running...
⚫ 2024-10-17 09:46:21 UTC Check cancelled

github-actions · 2024-10-17T09:48:02Z

⚪ 2024-10-17 09:48:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3ef7442 has started.
⚪ 2024-10-17 09:48:12 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:51:09 UTC ya make is running...
🟡 2024-10-17 10:46:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40280	34691	0	11	5480	98

⚪ 2024-10-17 10:49:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-17 11:00:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
108 (only retried tests)	4	0	10	0	94

⚪ 2024-10-17 11:01:05 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-17 11:12:16 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
104 (only retried tests)	1	0	10	0	93

🟢 2024-10-17 11:12:23 UTC Build successful.
🟢 2024-10-17 11:12:45 UTC ydbd size 2.8 GiB changed* by +37.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `a71cc84`	merge: `3ef7442`	diff	diff %
ydbd size	3 028 574 856 Bytes	3 028 612 712 Bytes	+37.0 KiB	+0.001%
ydbd stripped size	480 141 912 Bytes	480 146 648 Bytes	+4.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-17T09:50:27Z

⚪ 2024-10-17 09:50:27 UTC Pre-commit check linux-x86_64-release-asan for 3ef7442 has started.
⚪ 2024-10-17 09:50:37 UTC Artifacts will be uploaded here
⚪ 2024-10-17 09:53:40 UTC ya make is running...
🟡 2024-10-17 11:17:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10556	10155	0	87	275	39

🟢 2024-10-17 11:18:26 UTC Build successful.
🟢 2024-10-17 11:18:58 UTC ydbd size 5.7 GiB changed* by +83.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `a71cc84`	merge: `3ef7442`	diff	diff %
ydbd size	6 130 097 016 Bytes	6 130 182 408 Bytes	+83.4 KiB	+0.001%
ydbd stripped size	1 529 457 040 Bytes	1 529 469 200 Bytes	+11.9 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T09:45:56Z

⚪ 2024-10-21 09:45:55 UTC Pre-commit check linux-x86_64-release-asan for dae0e94 has started.
⚪ 2024-10-21 09:46:06 UTC Artifacts will be uploaded here
⚪ 2024-10-21 09:49:10 UTC ya make is running...
🟡 2024-10-21 11:11:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10392	10181	0	45	62	104

🟢 2024-10-21 11:12:18 UTC Build successful.
🟢 2024-10-21 11:12:51 UTC ydbd size 5.7 GiB changed* by +84.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `7f4d37b`	merge: `dae0e94`	diff	diff %
ydbd size	6 108 702 688 Bytes	6 108 788 664 Bytes	+84.0 KiB	+0.001%
ydbd stripped size	1 522 711 760 Bytes	1 522 723 728 Bytes	+11.7 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T09:45:59Z

⚪ 2024-10-21 09:45:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for dae0e94 has started.
⚪ 2024-10-21 09:49:01 UTC Artifacts will be uploaded here
⚪ 2024-10-21 09:52:09 UTC ya make is running...
🟡 2024-10-21 10:50:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40186	34582	0	3	5503	98

⚪ 2024-10-21 10:54:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-21 11:05:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
101 (only retried tests)	9	0	0	0	92

🟢 2024-10-21 11:06:02 UTC Build successful.
🟢 2024-10-21 11:06:20 UTC ydbd size 2.8 GiB changed* by +37.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `7f4d37b`	merge: `dae0e94`	diff	diff %
ydbd size	3 015 313 344 Bytes	3 015 351 216 Bytes	+37.0 KiB	+0.001%
ydbd stripped size	477 978 264 Bytes	477 983 000 Bytes	+4.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions bot added the improvement label Oct 16, 2024

nikvas0 closed this Oct 16, 2024

nikvas0 reopened this Oct 17, 2024

nikvas0 added 7 commits October 21, 2024 12:41

better-defer

a614bf4

fix

ae79111

fix

1363149

fix

5682c19

fix

adf8711

fix

fceab40

fix

8edc46b

nikvas0 force-pushed the test-improve-defer branch from 695d256 to 8edc46b Compare October 21, 2024 09:42

nikvas0 requested a review from ulya-sidorina October 21, 2024 11:22

nikvas0 enabled auto-merge (squash) October 21, 2024 11:29

gridnevvvit approved these changes Oct 24, 2024

View reviewed changes

nikvas0 merged commit 2878186 into ydb-platform:main Oct 24, 2024
10 checks passed

GrigoriyPA mentioned this pull request Oct 28, 2024

YQ RD fixed use after free #10978

Merged

shnikd mentioned this pull request Nov 7, 2024

Support CollectDiagnostics in DATA_QUERY/GENERIC_QUERY #11371

Open

niksaveliev mentioned this pull request Nov 8, 2024

Fix read session correct close ut #11407

Merged

GrigoriyPA mentioned this pull request Nov 13, 2024

YQ WM fixed race with actor context #11576

Merged

niksaveliev mentioned this pull request Nov 14, 2024

Commit for autopartitioned topics #11629

Open

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025

Improve tx defer (ydb-platform#10507)

b9c0122

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025

Improve tx defer (ydb-platform#10507)

2103178

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025

Improve tx defer (ydb-platform#10507)

2eab8c1

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025

Improve tx defer (ydb-platform#10507)

9f833a1

zverevgeny mentioned this pull request Jan 9, 2025

Integrate changes from main #13202

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve tx defer #10507

Improve tx defer #10507

nikvas0 commented Oct 16, 2024

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

Improve tx defer #10507

Improve tx defer #10507

Conversation

nikvas0 commented Oct 16, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading