Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kqp): allow null keys for stream join with secondary index #12363

Merged

Conversation

ulya-sidorina
Copy link
Collaborator

No description provided.

@ulya-sidorina ulya-sidorina linked an issue Dec 6, 2024 that may be closed by this pull request
@ulya-sidorina ulya-sidorina force-pushed the fix/stream_join_with_secondary_index branch 14 times, most recently from a18a41a to 5212a2d Compare December 6, 2024 18:11
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ulya-sidorina ulya-sidorina force-pushed the fix/stream_join_with_secondary_index branch from 5212a2d to 38faef7 Compare December 6, 2024 18:24
@ulya-sidorina ulya-sidorina marked this pull request as ready for review December 6, 2024 18:25
Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 18:26:07 UTC Pre-commit check linux-x86_64-release-asan for dcf8e20 has started.
2024-12-06 18:26:18 UTC Artifacts will be uploaded here
2024-12-06 18:29:32 UTC ya make is running...
🟡 2024-12-06 20:07:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15258 15185 0 21 6 46

🟢 2024-12-06 20:08:18 UTC Build successful.
🟢 2024-12-06 20:08:44 UTC ydbd size 4.9 GiB changed* by -64.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6b63b7d merge: dcf8e20 diff diff %
ydbd size 5 305 965 960 Bytes 5 305 899 960 Bytes -64.5 KiB -0.001%
ydbd stripped size 1 365 628 240 Bytes 1 365 606 160 Bytes -21.6 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 18:26:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for dcf8e20 has started.
2024-12-06 18:26:19 UTC Artifacts will be uploaded here
2024-12-06 18:29:41 UTC ya make is running...
🟡 2024-12-06 20:00:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32717 29876 0 6 2721 114

2024-12-06 20:03:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-06 20:16:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
837 (only retried tests) 729 0 2 0 106

2024-12-06 20:16:11 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-06 20:28:19 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
635 (only retried tests) 528 0 1 0 106

🟢 2024-12-06 20:28:28 UTC Build successful.
🟢 2024-12-06 20:28:49 UTC ydbd size 2.5 GiB changed* by -35.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6b63b7d merge: dcf8e20 diff diff %
ydbd size 2 699 421 808 Bytes 2 699 385 480 Bytes -35.5 KiB -0.001%
ydbd stripped size 483 524 944 Bytes 483 518 032 Bytes -6.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 6, 2024
@ssmike ssmike enabled auto-merge (squash) December 6, 2024 19:39
zinal added a commit to zinal/ydb that referenced this pull request Dec 6, 2024
@ssmike ssmike added the rebase-and-check Rebase PR with the current base branch and check label Dec 7, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

2024-12-07 08:23:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for aecadfc has started.
2024-12-07 08:23:32 UTC Artifacts will be uploaded here
2024-12-07 08:26:52 UTC ya make is running...
🟡 2024-12-07 09:26:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32717 29883 0 1 2722 111

2024-12-07 09:29:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-07 09:41:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
692 (only retried tests) 585 0 0 0 107

🟢 2024-12-07 09:42:03 UTC Build successful.
🟢 2024-12-07 09:42:22 UTC ydbd size 2.5 GiB changed* by -35.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6b63b7d merge: aecadfc diff diff %
ydbd size 2 699 421 808 Bytes 2 699 385 480 Bytes -35.5 KiB -0.001%
ydbd stripped size 483 524 944 Bytes 483 518 032 Bytes -6.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 7, 2024

2024-12-07 08:23:35 UTC Pre-commit check linux-x86_64-release-asan for aecadfc has started.
2024-12-07 08:23:46 UTC Artifacts will be uploaded here
2024-12-07 08:27:12 UTC ya make is running...
🟡 2024-12-07 09:41:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15258 15174 0 24 11 49

🟢 2024-12-07 09:43:01 UTC Build successful.
🟢 2024-12-07 09:43:30 UTC ydbd size 4.9 GiB changed* by -64.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6b63b7d merge: aecadfc diff diff %
ydbd size 5 305 965 960 Bytes 5 305 899 960 Bytes -64.5 KiB -0.001%
ydbd stripped size 1 365 628 240 Bytes 1 365 606 160 Bytes -21.6 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ssmike ssmike merged commit 817dc99 into ydb-platform:main Dec 7, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow null keys for stream lookup join with secondary index
2 participants