Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use removed portions before remove from local_db - prevent race … #12383

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

…with restore index vs remove portion

  • Bugfix

@github-actions github-actions bot added the bugfix label Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

2024-12-08 07:34:04 UTC Pre-commit check linux-x86_64-release-asan for 3fcb145 has started.
2024-12-08 07:34:14 UTC Artifacts will be uploaded here
2024-12-08 07:37:15 UTC ya make is running...
🟡 2024-12-08 08:42:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13139 13068 0 19 7 45

🟢 2024-12-08 08:43:47 UTC Build successful.
🟢 2024-12-08 08:44:12 UTC ydbd size 4.9 GiB changed* by +50.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 751da8a merge: 3fcb145 diff diff %
ydbd size 5 305 899 064 Bytes 5 305 951 136 Bytes +50.9 KiB +0.001%
ydbd stripped size 1 365 606 032 Bytes 1 365 613 584 Bytes +7.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 8, 2024

2024-12-08 07:34:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3fcb145 has started.
2024-12-08 07:34:40 UTC Artifacts will be uploaded here
2024-12-08 07:37:33 UTC ya make is running...
🟡 2024-12-08 08:26:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20656 19105 0 5 1425 121

2024-12-08 08:28:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-08 08:40:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
710 (only retried tests) 602 0 1 0 107

2024-12-08 08:40:41 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-08 08:52:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
644 (only retried tests) 538 0 0 0 106

🟢 2024-12-08 08:52:30 UTC Build successful.
🟢 2024-12-08 08:52:50 UTC ydbd size 2.5 GiB changed* by +17.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 751da8a merge: 3fcb145 diff diff %
ydbd size 2 699 385 352 Bytes 2 699 403 200 Bytes +17.4 KiB +0.001%
ydbd stripped size 483 518 032 Bytes 483 518 800 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 8, 2024 16:28
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 8, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants