Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader iterator unification #12387

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

Copy link

github-actions bot commented Dec 8, 2024

2024-12-08 15:13:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 65aaddf has started.
2024-12-08 15:13:28 UTC Artifacts will be uploaded here
2024-12-08 15:16:35 UTC ya make is running...
🟡 2024-12-08 16:09:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20682 19149 0 3 1417 113

2024-12-08 16:11:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-08 16:24:06 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
791 (only retried tests) 682 0 0 1 108

🟢 2024-12-08 16:24:16 UTC Build successful.
🟢 2024-12-08 16:24:35 UTC ydbd size 2.5 GiB changed* by -31.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 751da8a merge: 65aaddf diff diff %
ydbd size 2 699 385 352 Bytes 2 699 353 328 Bytes -31.3 KiB -0.001%
ydbd stripped size 483 518 032 Bytes 483 503 632 Bytes -14.1 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 8, 2024

2024-12-08 15:13:18 UTC Pre-commit check linux-x86_64-release-asan for 65aaddf has started.
2024-12-08 15:13:42 UTC Artifacts will be uploaded here
2024-12-08 15:16:34 UTC ya make is running...
🟡 2024-12-08 16:22:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13165 13097 0 20 5 43

🟢 2024-12-08 16:23:27 UTC Build successful.
🟢 2024-12-08 16:24:10 UTC ydbd size 4.9 GiB changed* by -132.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 751da8a merge: 65aaddf diff diff %
ydbd size 5 305 899 064 Bytes 5 305 763 792 Bytes -132.1 KiB -0.003%
ydbd stripped size 1 365 606 032 Bytes 1 365 582 480 Bytes -23.0 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 8, 2024

2024-12-08 16:25:46 UTC Pre-commit check linux-x86_64-release-asan for 9dfbd38 has started.
2024-12-08 16:26:10 UTC Artifacts will be uploaded here
2024-12-08 16:29:11 UTC ya make is running...
🟡 2024-12-08 17:33:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13165 13092 0 24 8 41

🟢 2024-12-08 17:34:47 UTC Build successful.
🟢 2024-12-08 17:35:16 UTC ydbd size 4.9 GiB changed* by -239.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 751da8a merge: 9dfbd38 diff diff %
ydbd size 5 305 899 064 Bytes 5 305 653 904 Bytes -239.4 KiB -0.005%
ydbd stripped size 1 365 606 032 Bytes 1 365 550 512 Bytes -54.2 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 8, 2024

2024-12-08 16:28:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9dfbd38 has started.
2024-12-08 16:29:02 UTC Artifacts will be uploaded here
2024-12-08 16:31:57 UTC ya make is running...
🟡 2024-12-08 17:23:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20682 19169 0 2 1398 113

2024-12-08 17:25:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-08 17:37:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
641 (only retried tests) 534 0 0 0 107

🟢 2024-12-08 17:37:58 UTC Build successful.
🟢 2024-12-08 17:38:16 UTC ydbd size 2.5 GiB changed* by -52.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 751da8a merge: 9dfbd38 diff diff %
ydbd size 2 699 385 352 Bytes 2 699 331 144 Bytes -52.9 KiB -0.002%
ydbd stripped size 483 518 032 Bytes 483 492 432 Bytes -25.0 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 8, 2024 16:29
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 8, 2024 16:29
@ivanmorozov333 ivanmorozov333 merged commit ed0816f into ydb-platform:main Dec 9, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the reader_iterator_unification branch December 9, 2024 09:50
iddqdex added a commit to iddqdex/ydb that referenced this pull request Dec 11, 2024
iddqdex added a commit to iddqdex/ydb that referenced this pull request Dec 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants