Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScalarOf.java:33-36: Continue implement class ScalarOf... #1349

Closed
0pdd opened this issue Apr 23, 2020 · 25 comments
Closed

ScalarOf.java:33-36: Continue implement class ScalarOf... #1349

0pdd opened this issue Apr 23, 2020 · 25 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 23, 2020

The puzzle 1320-62e15acb from #1320 has to be resolved:

* @todo #1320:30min Continue implement class ScalarOf that takes various
* objects such as a Supplier, Callable, etc and implement Scalar. Use it
* to replace in all places where it is needed. Add tests for each of the
* constructors.

The puzzle was created by marceloamadeu on 17-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2020

@paulodamaso/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2020

The job #1349 assigned to @Englishman/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@andreoss
Copy link
Contributor

andreoss commented Jun 15, 2020

@paulodamaso If implemented this will make new ScalarOf(() -> value) syntax ambiguous, and will require explicit cast to either of Supplier, Callable or Scalar. Is this intended?

@0crat
Copy link
Collaborator

0crat commented Jul 5, 2020

The architect of the project has changed; @paulodamaso/z is not at this role anymore; @victornoel/z is the architect now

@victornoel
Copy link
Collaborator

@0crat in

@victornoel
Copy link
Collaborator

@andreoss no, this is not intended, a solution would be to introduce various classes OfCallable, OfSupplier and Of would then take a Scalar I suppose.

@0crat
Copy link
Collaborator

0crat commented Jul 6, 2020

The job #1349 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @paulodamaso/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

@paulodamaso
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Jul 13, 2020

@0crat refuse (here)

@paulodamaso The user @paulodamaso/z resigned from #1349, please stop working. Reason for job resignation: Order was cancelled

@marceloamadeu
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Jul 13, 2020

@0crat refuse (here)

@marceloamadeu The user @marceloamadeu/z resigned from #1349, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Jul 13, 2020

@0crat refuse (here)

@marceloamadeu Job refused in 0 hours - no penalty, see §6

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2020

The job #1349 assigned to @longstone/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Jul 15, 2020

@0crat refuse (here)

@victornoel The user @longstone/z resigned from #1349, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Aug 8, 2020

The job #1349 assigned to @mazdack/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator

@0crat refuse

1 similar comment
@victornoel
Copy link
Collaborator

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Aug 23, 2020

@0crat refuse (here)

@victornoel The user @mazdack/z resigned from #1349, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Aug 23, 2020

@0crat refuse (here)

@victornoel Job gh:yegor256/cactoos#1349 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Sep 4, 2020

The job #1349 assigned to @andreoss/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@andreoss
Copy link
Contributor

andreoss commented Sep 4, 2020

@victornoel
Why ScalarOf should accept Callable and Supplier?
As a functional interface Scalar matches both of them, it will make lambda notation unambiguous and requiring explicit casting.

Can we have ScalarOfCallable instead?

@victornoel
Copy link
Collaborator

@andreoss yes, very good point. The name you propose is good to me, let's go with that.

andreoss added a commit to andreoss/cactoos that referenced this issue Sep 4, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 4, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 4, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 4, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 4, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 6, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 6, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 6, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 7, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 7, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 7, 2020
andreoss added a commit to andreoss/cactoos that referenced this issue Sep 7, 2020
@victornoel
Copy link
Collaborator

@andreoss ha, you forgot to remove the todo when you put ScalarOf back. Please make another PR.

andreoss added a commit to andreoss/cactoos that referenced this issue Sep 13, 2020
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 13, 2020

The puzzle 1320-62e15acb has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants