#1349: Continue of refactoring of ScalarOf

[andreoss]

Per #1349:

• Add ScalarOfSupplier
• Add ScalarOfCallable
• Remove ScalarOf

[codecov-commenter]

Codecov Report

Merging #1435 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1435      +/-   ##
============================================
+ Coverage     89.81%   89.82%   +0.01%     
- Complexity     1681     1683       +2     
============================================
  Files           279      281       +2     
  Lines          4014     4018       +4     
  Branches        211      211              
============================================
+ Hits           3605     3609       +4     
  Misses          376      376              
  Partials         33       33              

Impacted Files	Coverage Δ	Complexity Δ
...main/java/org/cactoos/scalar/ScalarOfCallable.java	100.00% <100.00%> (ø)	1.00 <1.00> (?)
...main/java/org/cactoos/scalar/ScalarOfSupplier.java	100.00% <100.00%> (ø)	1.00 <1.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79bca9...5870d73. Read the comment docs.

[victornoel]

@0crat assign @fabriciofx

[0crat]

@0crat assign @fabriciofx (here)

@victornoel This pull request #1435 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[fabriciofx]

@andreoss can you look it, please?

[andreoss]

@fabriciofx Please have a look

[fabriciofx]

@andreoss it looks fine to me, but now it has a conflict. Can you fix it?

[andreoss]

@fabriciofx Conflicts fixed.

[fabriciofx]

@andreoss please, can you check it again? Thanks!

[fabriciofx]

@andreoss it seems fine to me! Thanks!
@victornoel can you merge it, please?

[victornoel]

@andreoss let's keep ScalarOf anyway (taking a Scalar and extending ScalarEnvelope), even though it seems superfluous. And let's use it in ThreadsTest and TimedTest, there is no reason to rely on the concept of Callable there I believe.

[victornoel]

@andreoss scratch that, let me think a bit about it, sorry

[victornoel]

@andreoss ok, so:

• let's keep ScalarOf
• but let's use lambdas directly it in ThreadsTest and TimedTest, there is no reason to rely on the concept of Callable or use ScalarOf there I believe.

Btw ScalarOf will be improved as part of #1445 that's why we should keep it.

[andreoss]

@victornoel TimedTest uses CallableOf (not ScalarOfCallable), but it's unnecessary too. Do you want CallableOf removed from this test?

[victornoel]

@andreoss yes, that's what I meant, let's remove unneeded code :)

[andreoss]

@victornoel Restored ScalarOf, removed CallableOf from tests

[victornoel]

@andreoss thank you for your patience

[victornoel]

@rultor merge

[rultor]

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@victornoel Done! FYI, the full log is here (took me 10min)