Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rultor "stop" command issues wrong/confusing messages #864

Closed
carlosmiranda opened this issue Jun 12, 2015 · 11 comments
Closed

Rultor "stop" command issues wrong/confusing messages #864

carlosmiranda opened this issue Jun 12, 2015 · 11 comments
Labels

Comments

@carlosmiranda
Copy link

In https://github.com/teamed/xockets-layer/pull/359, I tried to stop Rultor but it failed (the PR was merged). It replied with this confusing message:

image

Look carefully, I asked it to merge and then tried to issue a @rultor stop command. However, it was able to proceed with the merge, but it quoted my "stop" message and said that it was "successful", when it fact it was not (the merge succeeded which meant the stop command failed).

The message is confusing. In this situation, it should say something like:

@carlosmiranda Sorry, I failed to stop the previous [merge/deploy/release] command, however it [succeeded/failed]. (took x mins.)

And then it should print the error trace if applicable (in case it failed).

@alex-palevsky
Copy link
Contributor

@yegor256 please pay attention to this issue

@yegor256 yegor256 added the bug label Jun 15, 2015
@alex-palevsky alex-palevsky added this to the 2.0 milestone Jun 15, 2015
@alex-palevsky
Copy link
Contributor

@carlosmiranda attached this issue to milestone "2.0" (let me know if this is wrong)

@alex-palevsky
Copy link
Contributor

@carlosmiranda many thanks for the bug report, I added 15 mins to your acc, transaction 59143332

@original-brownbear
Copy link
Contributor

@alex-palevsky this is urgent.

@alex-palevsky
Copy link
Contributor

@alex-palevsky this is urgent.

@original-brownbear right, I added "urgent" label

@alex-palevsky
Copy link
Contributor

@xupyprmv you may proceed, it's yours

@xupyprmv
Copy link
Contributor

@carlosmiranda PR #1046 was merged. Please close this ticket.

@carlosmiranda
Copy link
Author

@xupyprmv thanks!

@xupyprmv
Copy link
Contributor

@alex-palevsky PR #1046 was merged. This ticket is closed.

@alex-palevsky
Copy link
Contributor

@alex-palevsky PR #1046 was merged. This ticket is closed.

@xupyprmv thanks for that

@alex-palevsky
Copy link
Contributor

@xupyprmv 30 mins sent to your balance (ID AP-51A5220577577171K), many thanks! It took 117 hours and 33 mins.... +30 to your rating, your total score is +240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants