-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rultor "stop" command issues wrong/confusing messages #864
Comments
@yegor256 please pay attention to this issue |
@carlosmiranda attached this issue to milestone "2.0" (let me know if this is wrong) |
@carlosmiranda many thanks for the bug report, I added 15 mins to your acc, transaction |
@alex-palevsky this is urgent. |
@original-brownbear right, I added "urgent" label |
@xupyprmv you may proceed, it's yours |
@carlosmiranda PR #1046 was merged. Please close this ticket. |
@xupyprmv thanks! |
@alex-palevsky PR #1046 was merged. This ticket is closed. |
@xupyprmv thanks for that |
In https://github.com/teamed/xockets-layer/pull/359, I tried to stop Rultor but it failed (the PR was merged). It replied with this confusing message:
Look carefully, I asked it to merge and then tried to issue a
@rultor stop
command. However, it was able to proceed with the merge, but it quoted my "stop" message and said that it was "successful", when it fact it was not (the merge succeeded which meant the stop command failed).The message is confusing. In this situation, it should say something like:
And then it should print the error trace if applicable (in case it failed).
The text was updated successfully, but these errors were encountered: