#864 Correctly handle situation when report is created for stopped command. #1046
Conversation
|
@xupyprmv Thanks, let me find someone who can review this pull request |
|
@mkordas review this please |
|
@xupyprmv I'll do review today |
| * @param repo Repository | ||
| * @param issue Issue | ||
| * @return Example of Talk | ||
| * @throws IOException In case of error. |
There was a problem hiding this comment.
@xupyprmv dot at the end of this line is not needed, it will be soon prohibited by Qulice
|
@xupyprmv see my comments above |
|
@xupyprmv I did initial review above, I'll continue when you'll provide responses |
|
@mkordas Thanks for CR. I added comments to all your remarks. This is my first PR to Rultor project, so I can understand something in wrong way. Feel free to add remarks and correct me. |
|
@xupyprmv I'm checking again |
| /** | ||
| * Message bundle. | ||
| */ | ||
| private static final ResourceBundle PHRASES = |
There was a problem hiding this comment.
@xupyprmv we usually indent code like that:
private static final ResourceBundle PHRASES = ResourceBundle.getBundle(
"phrases"
);
|
@xupyprmv thanks for fixes, see additional comments above |
|
@mkordas Thanks for CR. I'm really appreciate your advice. Please continue. |
|
@xupyprmv see my response above about full check |
|
@mkordas full check was added. Please review. |
|
@xupyprmv looks nice! |
|
@rultor merge |
@mkordas Thanks for your request. @original-brownbear Please confirm this. |
|
@rultor merge please :) |
|
@xupyprmv thanks looks really nice ! |
@original-brownbear OK, I'll try to merge now. You can check the progress of the merge here |
@original-brownbear Done! FYI, the full log is here (took me 12min) |
|
@rultor deploy |
@mkordas Thanks for your request. @original-brownbear Please confirm this. |
|
@rultor deploy please :) |
@original-brownbear OK, I'll try to deploy now. You can check the progress here |
@original-brownbear Done! FYI, the full log is here (took me 7min) |
|
@rultor deploy pls |
@alex-palevsky OK, I'll try to deploy now. You can check the progress here |
@alex-palevsky Done! FYI, the full log is here (took me 9min) |
#864 I fixed Rultor behavior for situation when report is created for stopped command. Now it will add string:
Sorry, I failed to stop the previous command, however it has next result:to report message. I also added test to check this.