Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command/Output Ordering is messed up nondeterministically #901

Closed
sils opened this issue Jul 17, 2015 · 21 comments
Closed

Command/Output Ordering is messed up nondeterministically #901

sils opened this issue Jul 17, 2015 · 21 comments
Labels

Comments

@sils
Copy link
Contributor

sils commented Jul 17, 2015

See http://www.rultor.com/t/4530-122266254 the lines after + bash .misc/deploy.rultor.sh, first it echoes two ls commands, then it shows the output of the two ls commands and then it does the third command and its output.

So some ordering problem seems to be there.

@yegor256
Copy link
Owner

@sils1297 I can't find the content of .misc/deploy.rultor.sh in your repo, but I can only suspect that you have something like this there:

ls -la & ls -la

Am I right?

@sils
Copy link
Contributor Author

sils commented Jul 17, 2015

@yegor256 nope. It was

ls -la .
ls -la ..
ls -la .misc

@yegor256
Copy link
Owner

@sils1297 it's just technically not possible... can you show full code of your script?

@sils
Copy link
Contributor Author

sils commented Jul 17, 2015

@yegor256 just pushed it for you:

https://github.com/sils1297/coala/blob/sils/rultor/.misc/deploy.rultor.sh

as you can see from the commit sha it's the very same commit used in the log.

@yegor256
Copy link
Owner

@sils1297 I can't reproduce the problem... What do you have in .rultor.yml?

@sils
Copy link
Contributor Author

sils commented Jul 17, 2015

@yegor256 this branch points to the very same commit that resultet in the failure, here's the branch link:

https://github.com/sils1297/coala/tree/sils/rultor

thats the rultor.yml then: https://github.com/sils1297/coala/blob/sils/rultor/.rultor.yml

@yegor256 yegor256 added the bug label Sep 27, 2015
@alex-palevsky
Copy link
Contributor

@sils1297 we will find someone to do this task, soon

@alex-palevsky
Copy link
Contributor

@sils1297 since there is no milestone yet I set it to "2.0"

@alex-palevsky alex-palevsky added this to the 2.0 milestone Sep 27, 2015
@original-brownbear
Copy link
Contributor

@yegor256 since you asked, this is a result of output buffering occurring, since the containers are not ran in line buffered mode.
=> Output is dumped in 4096byte chunks.

Likely this can simply be fixed by running the container with the -t ( tty => line buffering) flag, but this needs to be investigated. Could be we have multiple spots where buffering can occur in the execution.

Pushed a small demo of this here: https://github.com/original-brownbear/output-buffering-docker
This should make it trivial to understand the issue for whoever deals with this.

@yegor256
Copy link
Owner

@original-brownbear interesting catch! well, let's try the -t flag?

@original-brownbear
Copy link
Contributor

@yegor256 yes, lets go for it :)

This was referenced Feb 23, 2016
@original-brownbear
Copy link
Contributor

@alex-palevsky assign me please.

@alex-palevsky
Copy link
Contributor

@alex-palevsky assign me please.

@original-brownbear yep, it is yours, go ahead

@original-brownbear
Copy link
Contributor

@yegor256 could you run the deploy on this one (#1023) ? :) , #982 still prevents me from doing that.

@yegor256
Copy link
Owner

@rultor deploy

@rultor
Copy link
Collaborator

rultor commented Feb 24, 2016

@rultor deploy

@yegor256 OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Feb 24, 2016

@rultor deploy

@yegor256 Done! FYI, the full log is here (took me 7min)

@original-brownbear
Copy link
Contributor

@sils1297 can you try again ? This issue should be resolved now :)

@sils
Copy link
Contributor Author

sils commented Feb 24, 2016

Hey, I don't have time to try it out, sorry.

@original-brownbear
Copy link
Contributor

@sils1297 no problem :), maybe you could still close this, given #1023 has been merged and I think clearly lays out ( and has a screenshot :) ) how and why this fixes this issue ?

@sils sils closed this as completed Feb 24, 2016
@alex-palevsky
Copy link
Contributor

@original-brownbear 45 mins sent to your balance (ID AP-1YD48006MS2809915), many thanks! It took 24 hours and 22 mins.; there is a bonus for fast delivery (m=1462); +45 added to your rating, current score is: +208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants