Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DyTask.java:46-46: Implement command method.... #423

Closed
davvd opened this issue Nov 4, 2014 · 19 comments
Closed

DyTask.java:46-46: Implement command method.... #423

davvd opened this issue Nov 4, 2014 · 19 comments

Comments

@davvd
Copy link
Collaborator

davvd commented Nov 4, 2014

Puzzle 406-e0d78f7e in src/main/java/com/thindeck/dynamo/DyTask.java:46-46 has to be resolved: Implement command method.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Collaborator Author

davvd commented Nov 5, 2014

@GregZuber please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have

Budget here is 30 mins (keep this principle in mind)

@GregZuber
Copy link

After running:

mvn clean install -Pqulice

I get error:

[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure

/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/FindTanksTest.java:[38,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/cockpit/ReposRsTest.java:[47,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyTasksTest.java:[42,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/cockpit/JxMemoTest.java:[37,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/scenarios/OnDeployTest.java:[37,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyUserTest.java:[44,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyUserTest.java:[45,19] package org.mockito does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/dynamo/DyBaseITCase.java:[40,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/dynamo/DyBaseITCase.java:[41,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/api/mock/MkMemoTest.java:[36,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/UpdateLBTest.java:[36,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/UpdateLBTest.java:[37,19] package org.mockito does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyRepoTest.java:[40,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyRepoTest.java:[41,19] package org.mockito does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/SwapTest.java:[40,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/cockpit/AccountRsTest.java:[36,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyReposTest.java:[43,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyBaseTest.java:[43,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/dynamo/DyBaseTest.java:[44,19] package org.mockito does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/life/LifecycleTest.java:[43,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/life/LifecycleTest.java:[44,19] package org.mockito does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/NginxTest.java:[46,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/NginxTest.java:[47,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/NginxTest.java:[48,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/NginxTest.java:[49,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/ReadConfigTest.java:[43,17] package org.junit does not exist
/home/g/workspace/teamedio/thindeck/src/test/java/com/thindeck/steps/FindTanksTest.java:[53,6] cannot find symbol

So it's obvious lack of this dependencies in pom.xml:

        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <version>4.11</version>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>org.mockito</groupId>
            <artifactId>mockito-all</artifactId>
            <version>1.8.4</version>
        </dependency>      

After adding them when running:

mvn clean pre-integration-test tomcat7:run-war

I still have one error:

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.017 sec <<< FAILURE! - in com.thindeck.scenarios.OnDeployTest
executesNecessarySteps(com.thindeck.scenarios.OnDeployTest)  Time elapsed: 0.017 sec  <<< ERROR!
java.lang.NoSuchMethodError: org.hamcrest.core.AllOf.allOf(Lorg/hamcrest/Matcher;Lorg/hamcrest/Matcher;)Lorg/hamcrest/Matcher;
    at org.hamcrest.Matchers.allOf(Matchers.java:33)
    at com.thindeck.scenarios.OnDeployTest.executesNecessarySteps(OnDeployTest.java:51)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:318)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)

// MANY OTHER TEST PASSES
[......................]


Results :

Tests in error: 
  OnDeployTest.executesNecessarySteps:51 » NoSuchMethod org.hamcrest.core.AllOf....

Tests run: 29, Failures: 0, Errors: 1, Skipped: 0

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] There are test failures.

Please refer to /home/g/workspace/teamedio/thindeck/target/surefire-reports for the individual test results.
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1 minute 9 seconds
[INFO] Finished at: Mon Nov 10 12:13:33 CET 2014
[INFO] Final Memory: 81M/416M
[INFO] ------------------------------------------------------------------------

When running:

mvn clean install -Pqulice

I got the same error.

So how to run this (when I skip tests in maven still got error):

mvn clean pre-integration-test tomcat7:run-war -Dmaven.test.skip=true
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] null
[INFO] ------------------------------------------------------------------------
[INFO] Trace
java.lang.NullPointerException
    at org.codehaus.plexus.component.configurator.converters.composite.CollectionConverter.fromConfiguration(CollectionConverter.java:181)
    at org.codehaus.plexus.component.configurator.converters.ComponentValueSetter.configure(ComponentValueSetter.java:247)
    at org.codehaus.plexus.component.configurator.converters.composite.ObjectWithFieldsConverter.processConfiguration(ObjectWithFieldsConverter.java:137)
    at org.codehaus.plexus.component.configurator.BasicComponentConfigurator.configureComponent(BasicComponentConfigurator.java:56)
    at org.apache.maven.plugin.DefaultPluginManager.populatePluginFields(DefaultPluginManager.java:1357)
    at org.apache.maven.plugin.DefaultPluginManager.getConfiguredMojo(DefaultPluginManager.java:724)
    at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:468)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
    at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
    at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
    at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
    at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

@yegor256
Copy link
Owner

first, you should run them from command line. obviously, you're doing it from IDE.

second, you need Maven 3.2+, your version is lower, I think

@davvd
Copy link
Collaborator Author

davvd commented Nov 18, 2014

@GregZuber check this "no obligations principle".. This task is on your name for at least 13 days. If you can't close it within the next 8 hours I'll have to assign someone else to it

@davvd
Copy link
Collaborator Author

davvd commented Nov 20, 2014

The description of the task was changed (see above). If anybody has any questions or concerns about this change, please express them right now. Otherwise, please work with the new version

@davvd
Copy link
Collaborator Author

davvd commented Nov 26, 2014

@GregZuber you've been working with this task for too long. I'm sorry, but I'll assign someone else. Please stop working with it. See our no obligations principle

@davvd davvd removed the @GregZuber label Nov 26, 2014
@davvd
Copy link
Collaborator Author

davvd commented Nov 26, 2014

@php-coder please proceed, it's yours

@php-coder
Copy link
Contributor

Probably, you forgot to add label with my nick to task.

@php-coder
Copy link
Contributor

I'll be busy next week, so I won't fix this ticket.

@davvd
Copy link
Collaborator Author

davvd commented Dec 10, 2014

@php-coder this task is in your hands for 13 days already

@php-coder
Copy link
Contributor

@davvd Yep, you may reassign it to someone else.

@yegor256
Copy link
Owner

@davvd please assign someone else here pls

@davvd
Copy link
Collaborator Author

davvd commented Dec 11, 2014

@davvd please assign someone else here pls

@yegor256 someone else will help in this task, no problem at all

@davvd davvd removed the @php-coder label Dec 11, 2014
@davvd
Copy link
Collaborator Author

davvd commented Dec 11, 2014

@adko-pl please go ahead with this task, it's yours

@davvd davvd added the @adko-pl label Dec 11, 2014
@adamsiemion
Copy link
Contributor

@davvd The command method is already implemented, it has been delivered in commit 89ac16e#diff-35db59e2308a4b976ba9825c7e270547 for issue #419

@yegor256
Copy link
Owner

@adko-pl good for you, just remove the puzzle and we're done here

@adamsiemion
Copy link
Contributor

@davvd pr #482 has been merged, please close this ticket

@davvd
Copy link
Collaborator Author

davvd commented Dec 25, 2014

It's closed now

@davvd davvd closed this as completed Dec 25, 2014
@davvd
Copy link
Collaborator Author

davvd commented Dec 25, 2014

@adko-pl 30 mins was added to your account, many thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants