Add merkleblock and proof of work check #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pebble8888 |
akifuji
reviewed
Sep 5, 2018
| // invalid bits | ||
| return false | ||
| } | ||
| if target == UInt256.zero { |
There was a problem hiding this comment.
guard is better than if.
This adapts to the following validations.
akifuji
reviewed
Sep 5, 2018
| @@ -103,6 +103,24 @@ public class PeerGroup: PeerDelegate { | |||
| } | |||
|
|
|||
| public func peer(_ peer: Peer, didReceiveMerkleBlockMessage message: MerkleBlockMessage, hash: Data) { | |||
| if !ProofOfWork.isValidProofOfWork(blockHash: hash, bits: message.bits) { | |||
|
I fixed it for the code review comment. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Add merkleblock message validity check.
You should look out that the validity check here is not enough to insert to the local database.
Moreover you need timestamp check and etc.
UInt256 is for PoW difficulty check.
This implementation is large for it.
I have not enough time to amend this PR unfortunately.
If the implementation doesn't match your design, please reject it or pick up what you need.
Alternate Designs
This check is implemented in BreadWallet.
I don't know we should check which message received.
Benefits
Prevent interpolation and attack.
Possible Drawbacks
Code maintainavility.
If a valid message is dropped, comment out the message check logic.
I tested some message is passed in test net.
Applicable Issues
None