Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify #153 #170

Merged
merged 8 commits into from
Sep 12, 2019
Merged

Modify #153 #170

merged 8 commits into from
Sep 12, 2019

Conversation

akifuji
Copy link
Contributor

@akifuji akifuji commented Sep 26, 2018

I modified #153 for the following the reasons.

  • Resolve conflict
  • Modify codes with Lint
  • Rename function names of test

@akifuji akifuji changed the title Develop Modify #153 Sep 26, 2018
@usatie
Copy link
Member

usatie commented Sep 12, 2019 •
edited
Loading

Remaining TODOs

usatie
usatie approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@usatie usatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usatie
Copy link
Member

usatie commented Sep 12, 2019

Big thanks to @pebble8888 and @akifuji.
@GitCash send 1000 bits to @pebble8888

@usatie usatie merged commit ab80dd6 into master Sep 12, 2019
@GitCash
Copy link

GitCash commented Sep 12, 2019

Hey pebble8888, user usatie tipped you 1000 bits in Bitcoin Cash ( ~ $0.295 ).

Click here to claim it!

You can also add the "thumbs down" reaction to usatie's comment above to prevent future tips.

@usatie usatie deleted the develop branch September 12, 2019 12:21
@usatie usatie mentioned this pull request Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usatie usatie usatie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akifuji @usatie @GitCash @pebble8888