Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node-gyp is included in npm already #301

Conversation

DavidVujic
Copy link
Collaborator

Remove node-gyp from dependencies.

Description

node-gyp is already included in Node/npm and node-gyp-build uses that one, so does prebuildify (if there isn't any other version specified locally). See Q&A about it here.

Motivation and Context

Less dependencies, will produce less weight in the node_modules folder and will probably speed up the install process.

How Has This Been Tested?

npm test ✅
npm run test-components ✅
npm run test-integration ✅
CircleCI ✅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic merged commit 725127d into yfinkelstein:master Jan 9, 2022
@DavidVujic DavidVujic deleted the remove_node_gyp_from_dev_dependencies branch January 9, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant