Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac OS X M1 prebuilds for Node.js 16.13.1 #302

Merged
merged 2 commits into from
Jan 9, 2022

Conversation

DavidVujic
Copy link
Collaborator

@DavidVujic DavidVujic commented Jan 9, 2022

Add Mac OS X M1 prebuilds for Node.js 16.13.1.

Description

I have added a prebuild for the M1 processor and when running in Node.js v16.13.1 (the current LTS).

Motivation and Context

Prebuilds will give a nicer developer experience: no need to compile the AddOn when doing npm install.

A tradeoff with prebuilds is that the weight of the package will be about 300kb heavier. This has been "evened out" by removing a lot of unnecessary dependencies (see pull request #301 and #301).

Fixes #286

How Has This Been Tested?

Run on a Macbook, with the M1 processor:
npm test ✅
npm run build-components ✅
npm run test-components ✅
docker-compose up --build integration-tests ✅

CircleCI ✅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic merged commit 560fb61 into yfinkelstein:master Jan 9, 2022
@DavidVujic DavidVujic deleted the m1_prebuilds branch January 9, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 16 prebuilds for Macs with the M1 processor (arm64 architecture)
1 participant