Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifacts on overview after dragging windows. #39

Closed
jntdofe opened this issue Aug 19, 2022 · 8 comments · Fixed by #51
Closed

Artifacts on overview after dragging windows. #39

jntdofe opened this issue Aug 19, 2022 · 8 comments · Fixed by #51
Labels
bug Something isn't working

Comments

@jntdofe
Copy link

jntdofe commented Aug 19, 2022 •
edited
Loading

After dragging a window on the overview it creates an artifact border on the bottom right of the window.

video.webm

it works both moving the window to other workspace or releasing it on the same workspace.

Edit: Extension Version 5, Fedora 36, Shell 42.3, Wayland, AMD integrated graphics.
@Nereboss
Copy link

Similar things happen when swapping from one workspace to another. All applications which are not minimized have a similar artifact border, all application that were minimized when opening the overview work correctly. When hovering over an application the artifact diappears.

Fedora 36, Gnome 42.4, Wayland, Intel integrated graphics
image

@AngleSideAngle
Copy link

Exact same behavior as Nereboss
Note that this only affects apps that the extension is enabled for.
Fedora 36, Gnome 42.4, Wayland

@sidevesh
Copy link

sidevesh commented Sep 1, 2022

Same here, for me those artifacts also show up sometimes when I switch between workspaces on overview screen,
Arch, Gnome 42.4, X11

@sevenzerotwo
Copy link

Screenshot from 2022-09-02 19-41-37
Same here, same behavior as sidevesh and Nereboss
Ubuntu 22.04.1, GNOME 42.2, X11

@yilozt yilozt added the bug Something isn't working label Sep 3, 2022
yilozt added a commit that referenced this issue Sep 4, 2022
@yilozt
Recompute position of shadow when drag window in overview
519ac52 
- Extract the code to compute the shadow in extensions.ts to
  utils/ui.ts (UI.UI.UpdateShadowOfWindowPreview)
- Connect `drag-end` signal to update shadow of window in overview
- Monkey patch imports.ui.workspacesView.WorkspacesView._scrollToActive
  to update shadow of window when switch workspace in overview.

Relative to #39
yilozt added a commit that referenced this issue Sep 4, 2022
@yilozt
Recompute position of shadow when drag window in overview
a1d7ace 
- Extract the code to compute the shadow in extensions.ts to
  utils/ui.ts (UI.UI.UpdateShadowOfWindowPreview)
- Connect `drag-end` signal to update shadow of window in overview
- Monkey patch imports.ui.workspacesView.WorkspacesView._scrollToActive
  to update shadow of window when switch workspace in overview.

Relative to #39
@yilozt
Copy link
Owner

yilozt commented Sep 4, 2022 •
edited
Loading

Should be fixed in a1d7ace, now artifacts should disappear when drag window & switch workspace in overview:

2022.09.04.18.53.13.webm
2022.09.04.18.53.51.webm

@yilozt
Copy link
Owner

yilozt commented Sep 4, 2022

There is still artifacts when type something in overview:

2022.09.04.21.33.40.webm

@sidevesh
Copy link

sidevesh commented Sep 6, 2022

I don't see the glitch happening when typing something in overview on my system,
is the new commit which fixed the previous two glitches pushed to gnome extensions ?

@yilozt yilozt mentioned this issue Sep 7, 2022
Merged
@yilozt
Copy link
Owner

yilozt commented Sep 8, 2022

Should be fixed in #51, you can reopen this issue if artifacts still appears in overview.

@yilozt yilozt closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allocate shadow actor when position & size of window changed yilozt/rounded-window-corners
6 participants
@sidevesh @yilozt @jntdofe @AngleSideAngle @sevenzerotwo @Nereboss