Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate shadow actor when position & size of window changed #51

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

yilozt
Copy link
Owner

@yilozt yilozt commented Sep 7, 2022

Create a class named OverviewShadowActor in extensions.ts to copy shadow of rounded corners window and insert it to behind of window preview in overview, also override vfunc_allocate() method so that when size of window changed in overview, size&position of shadow will be updated correctly.

This PR can clear the warning error when opening/closing overview (Fix #50), and also clear artifacts in overview (Fix #39):

2022.09.08.14.22.54.webm

@yilozt yilozt self-assigned this Sep 7, 2022
@yilozt yilozt marked this pull request as draft September 7, 2022 20:01
@yilozt yilozt force-pushed the allocate-actor-for-overview-shadow branch 4 times, most recently from a635736 to bc9b942 Compare September 8, 2022 06:44
@yilozt yilozt marked this pull request as ready for review September 8, 2022 09:46
@yilozt yilozt changed the title Draft: Allocate shadow actor when position & size of window changed Allocate shadow actor when position & size of window changed Sep 8, 2022
@yilozt yilozt force-pushed the allocate-actor-for-overview-shadow branch from bc9b942 to b5326b1 Compare September 8, 2022 09:52
@yilozt yilozt merged commit c56008f into main Sep 8, 2022
@yilozt yilozt deleted the allocate-actor-for-overview-shadow branch September 8, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of warning when opening/closing overview Artifacts on overview after dragging windows.
1 participant