feat: add OpenShift exceptions #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(formatOutput): fix spacing between tables * fix * refactor * refactor --------- Co-authored-by: Phil Brocker <[email protected]>
* feat: added clusterroles * feat: added k3s configmaps * feat: added k3s crds * feat: added k3s secrets * feat: added k3s StorageClass * feat: added job resource exceptions * feat: added job exceptions * fix: importing embed
Signed-off-by: Mahdi <[email protected]>
* Update PR template * Add docs checkbox
* docs: add values.yaml descriptions to README.md * docs: updated chart version in readme * Update charts/kor/Chart.yaml Co-authored-by: Yonah Dissen <[email protected]> * docs: updated chart description in readme --------- Co-authored-by: Yonah Dissen <[email protected]>
* Feat: add failed jobs as unused * Update jobs.go * add tests * Update jobs in readme * Update jobs.go * Update jobs_test.go * Fix test * Update jobs_test.go * Update jobs_test.go * Update jobs_test.go * Update jobs_test.go * fix CR * Update jobs_test.go
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 40.96% 40.96%
=======================================
Files 58 58
Lines 2910 2910
=======================================
Hits 1192 1192
Misses 1530 1530
Partials 188 188 ☔ View full report in Codecov by Sentry. |
There are various unused resources in 30+ default OpenShift ExceptionsAwaiting #249 to be merged and then I'll apply that logic in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR excludes the default resources created in basic OpenShift installations.
PR Checklist
GitHub Issue
Closes #240
Notes for your reviewers
In
pkg/kor/secrets.go, a new exception secret type was added -kubernetes.io/dockercfg, which is the OpenShift equivalent ofkubernetes.io/dockerconfigjson.This PR addresses all default namespaces that doesn't begin with
openshift-prefix.Meaning, it covers the following namespaces:
openshift,default,kube-system,kube-public,kube-node-lease&assisted-installer.Basic OpenShift installation comes with 60+ namespaces beginning with
openshift-prefix, which doesn't include additional namespaces created by OpenShift operators or customized installations, that would also be created with that prefix.As I see it, there are 3 options to address this case:
openshift-prefix (flexible).@yonahd please share your thoughts, I'm leaning towards option no. (1).