Prefer default Debug and Release configs #752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default schemes generated for a target is using the
suitableConfig
helper function to prefer configs named "Debug" or "Release" over the alphabetically first scheme of the matching type:XcodeGen/Sources/XcodeGenKit/SchemeGenerator.swift
Lines 57 to 58 in 480477a
but
generateScheme(_: Scheme)
was using the computeddefault<ConfigType>Config
properties which only took into account the sorting order for top level schemes.XcodeGen/Sources/XcodeGenKit/SchemeGenerator.swift
Lines 244 to 250 in 480477a
This change uses the same
suitableConfig
function to back thedefault<ConfigType>Config
properties so that top level schemes and target schemes will have the same default config behavior.